Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span_near query should accept slop = -1 (bis) #3673

Closed
iksnalybok opened this Issue Sep 12, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@iksnalybok
Copy link
Contributor

commented Sep 12, 2013

Hi,

Previous fix (#3122) for issue #3079 (span_near query should accept slop = -1) is incomplete. Similar fix (e.g change int slop = -1; into Integer slop = null;) should also be applied in src/main/java/org/elasticsearch/index/query/SpanNearQueryBuilder.java.

Could you please also make the fix available in the 0.90.x branch ?

Thanks

@ghost ghost assigned javanna Sep 12, 2013

@javanna

This comment has been minimized.

Copy link
Member

commented Sep 12, 2013

Right I see what you mean. @iksnalybok do you want to send a pull request for this?

@iksnalybok

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2013

cf pull 3683 (master branch)

NB: do I need to create another for the 0.90.x branch ?

@javanna

This comment has been minimized.

Copy link
Member

commented Sep 13, 2013

@iksnalybok one pull request against master is enough, we can then cherry pick the commit to backport it to 0.90. Thanks!

@iksnalybok

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2013

I could not clean the pull request log in a reasonable amount of time. Would you mind doing the fix yourself ? Thanks.

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2013

Does the hack that this allows deserve a documentation update?

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.