Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestedFieldComparator misses to copy slot if root doc has docID==0 and 'Avg' is used #3706

Closed
s1monw opened this Issue Sep 16, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@s1monw
Copy link
Contributor

s1monw commented Sep 16, 2013

The average NestedFieldComparator doesn't copy the underlying Comparator slot if rootDoc == 0. This was triggered by some of our tests lately.

@ghost ghost assigned s1monw Sep 16, 2013

@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Sep 16, 2013

Nice catch!

@s1monw s1monw closed this in 5396d8e Sep 16, 2013

s1monw added a commit that referenced this issue Sep 16, 2013

Copy slow in wrapped comparator even if root doc is the first doc in the
segment.

We missed to copy the slot if the root doc is the first doc in the
segment.

Closes #3706

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Copy slow in wrapped comparator even if root doc is the first doc in the
segment.

We missed to copy the slot if the root doc is the first doc in the
segment.

Closes elastic#3706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.