Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Fix esType for DATETIME/DATE and INTERVALS #38051

Closed
matriv opened this issue Jan 30, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@matriv
Copy link
Contributor

commented Jan 30, 2019

Currently esType is just a lowercase of the DataType.
Since esType is used for calls to unmappedType() this must be fixed, as for DATETIME it should be date and for ES-SQL types only like DATE and INTERVAL types it should be unsupported operation.

@elasticmachine

This comment has been minimized.

Copy link

commented Jan 30, 2019

@matriv matriv self-assigned this Jan 30, 2019

matriv added a commit to matriv/elasticsearch that referenced this issue Feb 1, 2019

SQL: Fix esType for DATETIME/DATE and INTERVALS
Since introduction of data types that don't have a corresponding type
in ES the `esType` is error-prone when used for `unmappedType()` calls.
Moreover since the renaming of `DATE` to `DATETIME` and the introduction
of an actual date-only `DATE` the `esType` would return `datetime` which
is not a valid type for ES mapping.

Fixes: elastic#38051

@matriv matriv closed this in #38179 Feb 5, 2019

matriv added a commit that referenced this issue Feb 5, 2019

SQL: Fix esType for DATETIME/DATE and INTERVALS (#38179)
Since introduction of data types that don't have a corresponding type
in ES the `esType` is error-prone when used for `unmappedType()` calls.
Moreover since the renaming of `DATE` to `DATETIME` and the introduction
of an actual date-only `DATE` the `esType` would return `datetime` which
is not a valid type for ES mapping.

Fixes: #38051

matriv added a commit that referenced this issue Feb 5, 2019

SQL: Fix esType for DATETIME/DATE and INTERVALS (#38179)
Since introduction of data types that don't have a corresponding type
in ES the `esType` is error-prone when used for `unmappedType()` calls.
Moreover since the renaming of `DATE` to `DATETIME` and the introduction
of an actual date-only `DATE` the `esType` would return `datetime` which
is not a valid type for ES mapping.

Fixes: #38051

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Feb 12, 2019

SQL: Fix esType for DATETIME/DATE and INTERVALS (elastic#38179)
Since introduction of data types that don't have a corresponding type
in ES the `esType` is error-prone when used for `unmappedType()` calls.
Moreover since the renaming of `DATE` to `DATETIME` and the introduction
of an actual date-only `DATE` the `esType` would return `datetime` which
is not a valid type for ES mapping.

Fixes: elastic#38051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.