Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: StackOverflow circuit breaker kicks in for IN with a long list of numbers #38571

Closed
matriv opened this issue Feb 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@matriv
Copy link
Contributor

commented Feb 7, 2019

Long list of numbers (positive and negative) inside IN kicks in when 200 numbers are encountered.
This shouldn't be the case as constants (numbers or strings) don't contribute to the increase of the stack.

@matriv matriv self-assigned this Feb 7, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Feb 7, 2019

matriv added a commit to matriv/elasticsearch that referenced this issue Feb 7, 2019

SQL: Relax StatckOverflow circuit breaker for constants
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: elastic#38571

@matriv matriv closed this in #38572 Feb 9, 2019

matriv added a commit that referenced this issue Feb 9, 2019

SQL: Relax StackOverflow circuit breaker for constants (#38572)
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571

matriv added a commit that referenced this issue Feb 9, 2019

SQL: Relax StackOverflow circuit breaker for constants (#38572)
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571

matriv added a commit that referenced this issue Feb 9, 2019

SQL: Relax StackOverflow circuit breaker for constants (#38572)
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571

matriv added a commit that referenced this issue Feb 9, 2019

SQL: Relax StackOverflow circuit breaker for constants (#38572)
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571

matriv added a commit that referenced this issue Feb 9, 2019

SQL: Relax StackOverflow circuit breaker for constants (#38572)
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Feb 12, 2019

SQL: Relax StackOverflow circuit breaker for constants (elastic#38572)
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: elastic#38571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.