Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bin/plugin --install" reports success for aborted installations #3882

Closed
benmccann opened this Issue Oct 11, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@benmccann
Copy link
Contributor

benmccann commented Oct 11, 2013

It looks like it happened successfully, but it actually aborted:

$ sudo /usr/share/elasticsearch/bin/plugin --install richardwilly98/elasticsearch-river-mongodb/1.7.1
-> Installing richardwilly98/elasticsearch-river-mongodb/1.7.1...
Trying http://download.elasticsearch.org/richardwilly98/elasticsearch-river-mongodb/elasticsearch-river-mongodb-1.7.1.zip...
Trying http://search.maven.org/remotecontent?filepath=richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip...
Trying https://oss.sonatype.org/service/local/repositories/releases/content/richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip...
Trying https://github.com/richardwilly98/elasticsearch-river-mongodb/archive/v1.7.1.zip...
Trying https://github.com/richardwilly98/elasticsearch-river-mongodb/archive/master.zip...
Downloading .................DONE
Installed richardwilly98/elasticsearch-river-mongodb/1.7.1 into /usr/share/elasticsearch/plugins/river-mongodb

$ sudo ls /usr/share/elasticsearch/plugins/river-mongodb
ls: cannot access /usr/share/elasticsearch/plugins/river-mongodb: No such file or directory
@dadoonet

This comment has been minimized.

Copy link
Member

dadoonet commented Oct 11, 2013

Are you using an old version of elasticsearch?

When I test it on 0.90.6-SNAPSHOT, I get:

-> Installing richardwilly98/elasticsearch-river-mongodb/1.7.1...
Trying http://download.elasticsearch.org/richardwilly98/elasticsearch-river-mongodb/elasticsearch-river-mongodb-1.7.1.zip...
Failed: IOException[Can't get http://download.elasticsearch.org/richardwilly98/elasticsearch-river-mongodb/elasticsearch-river-mongodb-1.7.1.zip to /Users/dpilato/Documents/Elasticsearch/dev/elasticsearch/plugins/river-mongodb.zip]; nested: FileNotFoundException[http://download.elasticsearch.org/richardwilly98/elasticsearch-river-mongodb/elasticsearch-river-mongodb-1.7.1.zip]; nested: FileNotFoundException[http://download.elasticsearch.org/richardwilly98/elasticsearch-river-mongodb/elasticsearch-river-mongodb-1.7.1.zip]; 
Trying http://search.maven.org/remotecontent?filepath=richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip...
Failed: IOException[Can't get http://search.maven.org/remotecontent?filepath=richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip to /Users/dpilato/Documents/Elasticsearch/dev/elasticsearch/plugins/river-mongodb.zip]; nested: FileNotFoundException[http://search.maven.org/remotecontent?filepath=richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip]; nested: FileNotFoundException[http://search.maven.org/remotecontent?filepath=richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip]; 
Trying https://oss.sonatype.org/service/local/repositories/releases/content/richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip...
Failed: IOException[Can't get https://oss.sonatype.org/service/local/repositories/releases/content/richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip to /Users/dpilato/Documents/Elasticsearch/dev/elasticsearch/plugins/river-mongodb.zip]; nested: FileNotFoundException[https://oss.sonatype.org/service/local/repositories/releases/content/richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip]; nested: FileNotFoundException[https://oss.sonatype.org/service/local/repositories/releases/content/richardwilly98/elasticsearch-river-mongodb/1.7.1/elasticsearch-river-mongodb-1.7.1.zip]; 
Trying https://github.com/richardwilly98/elasticsearch-river-mongodb/archive/v1.7.1.zip...
Failed: IOException[Can't get https://github.com/richardwilly98/elasticsearch-river-mongodb/archive/v1.7.1.zip to /Users/dpilato/Documents/Elasticsearch/dev/elasticsearch/plugins/river-mongodb.zip]; nested: FileNotFoundException[https://codeload.github.com/richardwilly98/elasticsearch-river-mongodb/zip/v1.7.1]; nested: FileNotFoundException[https://codeload.github.com/richardwilly98/elasticsearch-river-mongodb/zip/v1.7.1]; 
Trying https://github.com/richardwilly98/elasticsearch-river-mongodb/archive/master.zip...
Downloading ..................................................DONE
Installed richardwilly98/elasticsearch-river-mongodb/1.7.1 into /Users/dpilato/Documents/Elasticsearch/dev/elasticsearch/plugins/river-mongodb
Plugin installation assumed to be site plugin, but contains source code, aborting installation...
Usage:
    -u, --url     [plugin location]   : Set exact URL to download the plugin from
    -i, --install [plugin name]       : Downloads and installs listed plugins [*]
    -r, --remove  [plugin name]       : Removes listed plugins
    -l, --list                        : List installed plugins
    -v, --verbose                     : Prints verbose messages
    -s, --silent                      : Run in silent mode
    -h, --help                        : Prints this help message

 [*] Plugin name could be:
     elasticsearch/plugin/version for official elasticsearch plugins (download from download.elasticsearch.org)
     groupId/artifactId/version   for community plugins (download from maven central or oss sonatype)
     username/repository          for site plugins (download from github master)

Message:
   Error while installing plugin, reason: IllegalArgumentException: Plugin installation assumed to be site plugin, but contains source code, aborting installation.

Process finished with exit code 70

Which is good to me. I mean it does not fail silently.

@benmccann

This comment has been minimized.

Copy link
Contributor Author

benmccann commented Oct 11, 2013

I'm using 0.90.5. Maybe there's been some change that will fix it for the next release?

@javanna

This comment has been minimized.

Copy link
Member

javanna commented Oct 14, 2013

Indeed, this is the pull request #3774 but there is no related issue, which makes it harder to trace. Going to be fixed with 0.90.6.

Thanks for opening this though!

@javanna javanna closed this Oct 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.