Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BootStrapTests.testLoadExistingWatchesUponStartup fails #39087

Closed
tvernum opened this issue Feb 19, 2019 · 2 comments · Fixed by #39092
Closed

BootStrapTests.testLoadExistingWatchesUponStartup fails #39087

tvernum opened this issue Feb 19, 2019 · 2 comments · Fixed by #39092
Assignees
@tvernum
Labels
:Data Management/Watcher >test-failure Triaged test failures from CI

Comments

@tvernum
Copy link
Contributor

tvernum commented Feb 19, 2019

This test is annotated @AwaitsFix on an old issue that was theoretically resolved by c65528b.

However it still fails (inconsistently) on master if the annotation is removed.
@tvernum tvernum added >test-failure Triaged test failures from CI :Data Management/Watcher labels Feb 19, 2019
@tvernum tvernum self-assigned this Feb 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@tvernum
Copy link
Contributor Author

tvernum commented Feb 19, 2019

I only raised this issue to make it clear that I'm looking at that existing @AwaitsFix in case anyone else stumbled on to it.

tvernum added a commit to tvernum/elasticsearch that referenced this issue Feb 19, 2019
@tvernum
Resolve concurrency with watcher trigger service
cf0706e 
The watcher trigger service could attempt to modify the perWatchStats
map simultaneously from multiple threads. This would cause the
internal state to become inconsistent, in particular the count()
method may return an incorrect value for the number of watches.

This changes replaces the implementation of the map with a
ConcurrentHashMap so that its internal state remains consistent even
when accessed from mutiple threads.

Resolves: elastic#39087
@tvernum tvernum mentioned this issue Feb 19, 2019
Merged
tvernum added a commit that referenced this issue Feb 19, 2019
@tvernum
Resolve concurrency with watcher trigger service (#39092)
e694473 
The watcher trigger service could attempt to modify the perWatchStats
map simultaneously from multiple threads. This would cause the
internal state to become inconsistent, in particular the count()
method may return an incorrect value for the number of watches.

This changes replaces the implementation of the map with a
ConcurrentHashMap so that its internal state remains consistent even
when accessed from mutiple threads.

Resolves: #39087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvernum tvernum

Labels
:Data Management/Watcher >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve concurrency with watcher trigger service tvernum/elasticsearch
2 participants
@tvernum @elasticmachine