Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename and document "index.mapping.date.parse_upper_inclusive" setting for date fields #3914

Closed
brwe opened this Issue Oct 15, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@brwe
Copy link
Contributor

commented Oct 15, 2013

The "upper_inclusive" suffix is misleading. The setting really triggers rounding up of range boundaries for the range filter and query. Also, this setting is undocumented.

brwe added a commit to brwe/elasticsearch that referenced this issue Oct 28, 2013

rename and document "index.mapping.date.parse_upper_inclusive" settin…
…g for date fields

The setting causes the upper bound for a range query/filter to be rounded up,
therefore the name `round_ceil` seems to make more sense.

Also this commit removes the redundant fourth parameter to DateMathParser.parse(..)
which was never used.
was:    parse(String text, long now, boolean roundUp, boolean upperInclusive)
is now: parse(String text, long now, boolean roundCeil)

closes elastic#3914

@brwe brwe closed this in c9dab69 Oct 28, 2013

brwe added a commit that referenced this issue Oct 28, 2013

rename and document "index.mapping.date.parse_upper_inclusive" settin…
…g for date fields

The setting causes the upper bound for a range query/filter to be rounded up,
therefore the name `round_ceil` seems to make more sense.

Also this commit removes the redundant fourth parameter to DateMathParser.parse(..)
which was never used.
was:    parse(String text, long now, boolean roundUp, boolean upperInclusive)
is now: parse(String text, long now, boolean roundCeil)

closes #3914

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

rename and document "index.mapping.date.parse_upper_inclusive" settin…
…g for date fields

The setting causes the upper bound for a range query/filter to be rounded up,
therefore the name `round_ceil` seems to make more sense.

Also this commit removes the redundant fourth parameter to DateMathParser.parse(..)
which was never used.
was:    parse(String text, long now, boolean roundUp, boolean upperInclusive)
is now: parse(String text, long now, boolean roundCeil)

closes elastic#3914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.