Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deprecation Info API checks for 8.0 #42404

Closed
80 tasks done
gwbrown opened this issue May 22, 2019 · 6 comments · Fixed by #76513, #76516, #76627, #76944 or #76954
Closed
80 tasks done

Update Deprecation Info API checks for 8.0 #42404

gwbrown opened this issue May 22, 2019 · 6 comments · Fixed by #76513, #76516, #76627, #76944 or #76954
Labels
:Data Management/Stats Statistics tracking and retrieval APIs Meta Team:Data Management Meta label for data/management team

Comments

@gwbrown
Copy link
Contributor

gwbrown commented May 22, 2019

This issue is intended to track breaking changes for 8.0 which need a deprecation check implemented in the Deprecation Info API as they are made. While we will still need a review prior to the release of 8.0, the intention is that we can work on implementing these checks as the breaking changes are made, or at least keep a running list of which ones need checks rather than having to go through all >breaking PRs.

In order to be checkable by the Deprecation Info API, the issue must be detectable by examining one of the following:

  1. ClusterState
  2. IndexMetaData
  3. Node-local information (e.g. settings, plugins, etc.)
  4. DatafeedConfig

REST API changes, or problems which are only detectable by examining the contents of the index, rather than the mapping/settings, probably don't go here, but please ask if you're unsure.

Deprecation checks should generally be added to the 7.x branch. You can find the appropriate classes here. View the 6.8 branch for a number of examples if you need more examples than are present in 7.x.

The List

Not needed list

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@ppf2
Copy link
Member

ppf2 commented May 23, 2019

Curious about #25127 (comment). Are inline and stored still valid on 8.0 (despite previous deprecation) or will it be part of this list?

@gwbrown
Copy link
Contributor Author

gwbrown commented May 23, 2019

I don't see a PR labelled >breaking that removed inline/stored yet - this list only includes breaking changes that have a PR open or are already merged. The Deprecation Info API is intended to only include things that will either break or have different behavior in the next major version to make it easier for users to upgrade, rather than pointing out any usage of deprecated features.

I'm also not a painless expert, but it looks like inline/stored are primarily used as part of requests, rather than being part of the cluster/index configuration and metadata, which is outside the scope of the deprecation info API. Correct me if I'm wrong here, though.

@ppf2
Copy link
Member

ppf2 commented May 23, 2019

I was previously thinking about scripts that may end up making it into the cluster state like ML datafeed configs, but those should have migrated to persistent tasks by 8.0, so you are right, the script thing is probably not relevant here :) thx!

@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
@masseyke masseyke linked a pull request Aug 17, 2021 that will close this issue
@masseyke masseyke linked a pull request Aug 25, 2021 that will close this issue
@masseyke masseyke linked a pull request Aug 26, 2021 that will close this issue
masseyke added a commit that referenced this issue Sep 1, 2021
The following properties have been removed from the geo_shape data type in 8.0: "strategy",
"tree", "tree_levels", "precision", "distance_error_pct", "points_only". This PR adds a deprecation
info API check for indexes and templates that have any of these properties in their mappings.

Relates #42404 #70850
masseyke added a commit that referenced this issue Sep 1, 2021
…6986)

This commit adds deprecation info API messages for three obsolete security settings which have been
removed: "xpack.security.authc.accept_default_password",
"xpack.security.authz.store.roles.index.cache.max_size", and "xpack.security.authz.store.roles.index.cache.ttl"
Relates #42404 #40496
masseyke added a commit that referenced this issue Sep 1, 2021
The search.remote.* properties have been removed in 8.0 and replaced with cluster.remote.* properties.
This adds a check for these properties in the deprecation info API.
Relates #42404 and #42381
masseyke added a commit that referenced this issue Sep 2, 2021
The cluster.join.timeout setting has been removed in 8.0. This commit adds a deprecation info
check for that setting.
Relates #42404 #60873
masseyke added a commit that referenced this issue Sep 2, 2021
The "node.max_local_storage_nodes" property has been removed in 8.0. This commit adds a deprecation
info API check for the property.
Relates #42404 #42428
masseyke added a commit that referenced this issue Sep 2, 2021
…settings (#76995)

The fixed_auto_queue_size threadpool has been removed in 8.0. This commit checks for configuration that is
specific to that threadpool type and issues a deprecation info API message about it.
Relates #42404 #52280
masseyke added a commit that referenced this issue Sep 2, 2021
…ettings (#77042)

The ability to delay cluster state recovery once a majority of master eligible nodes has joined has
been removed in 8.0. This commit checks for settings that are related, and issues a deprecation
info API message about it.
Relates #42404 #53845
masseyke added a commit that referenced this issue Sep 2, 2021
#76999)

In 8.0, access to the transport client has been removed, so the transport.profiles.*.xpack.security.type
setting is gone. This commit adds a deprecation info API check for this property.
Relates #42404 #43236
masseyke added a commit that referenced this issue Sep 3, 2021
The system property "es.unsafely_permit_handshake_from_incompatible_builds" was deprecated and has
been removed in 8.0. This adds a deprecation check for that property.
Relates to #42404 and #65753.
masseyke added a commit that referenced this issue Sep 3, 2021
…settings (#77092)

In 8.0 we prevent the server from starting up if certain SSL properties are misconfigured or ambiguous. Specifically:
1) The server lacks a certificate/key pair (i.e. neither ssl.keystore.path nor ssl.key/ssl.certificate are configured)
2) The server has some ssl configuration, but ssl.enabled is not specified.
This commit adds a check to the deprecation info API for these changes.
Relates #42404 #45892
masseyke added a commit that referenced this issue Sep 3, 2021
In 8.0 the ability to have a positive "xpack.searchable.snapshot.shared_cache.size" on a non-frozen node
has been removed. This commit adds a deprecation info API check if a non-frozen node has a positive
 "xpack.searchable.snapshot.shared_cache.size".
Relates #42404 #71013
masseyke added a commit that referenced this issue Sep 7, 2021
#77074)

In 6.2.0 we deprecated support for fractional byte value settings. Support was originally going to be
removed altogether in 8.0.0 (see #53927) but that PR was not merged. This commit adds a warning
deprecation info check if any fractional byte values settings are found.
Relates #42404
masseyke added a commit that referenced this issue Sep 7, 2021
Fixed wording in the details message for the deprecation info API for geo_shape fields.
Relates #42404 #76627
masseyke added a commit that referenced this issue Sep 7, 2021
The sparse_vector type is deprecated and has been removed in 8.0. This commit adds a deprecation info API
message if we detect templates with mappings that include sparse_vector fields.
Relates #42404 #48781
masseyke added a commit that referenced this issue Sep 15, 2021
Many of the URLs for deprecation info messages were broken (returned 404s), or referenced "master"
or "current", which are likely to break in the future. This commit updates all of the ones that can currently
be fixed.
Relates #42404
masseyke added a commit that referenced this issue Sep 15, 2021
In 8.0 the behavior of an unset saml nameid_format setting. This commit adds a check to the deprecation
info API that warns users of this change, if they are using saml without nameid_format being set.
Relates #42404 #44090
masseyke added a commit that referenced this issue Sep 21, 2021
This commit updates the deprecation info API to use shortened https://ela.st URLs that can be adjusted to point to
different documentation URLs without having to modify the source code.
Relates #42404
masseyke added a commit that referenced this issue Sep 21, 2021
…ion (#77969)

As part of deprecating frozen indices in favor of the frozen tier, this commit deprecates the ILM freeze action. This
includes a deprecation log message at runtime, as well as a deprecation info API check.
Relates #70192 #42404
@dakrone dakrone added :Data Management/Stats Statistics tracking and retrieval APIs and removed :Data Management/Other labels Nov 16, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gwbrown
Copy link
Contributor Author

gwbrown commented Nov 28, 2023

This should have been closed a long time ago - 8.0 is long since out and these checks completed!

@gwbrown gwbrown closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment