New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of ways to highlight boost phrase matches over general term matches in score order highlighted fragments don't work #4351

Closed
nik9000 opened this Issue Dec 5, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@nik9000
Contributor

nik9000 commented Dec 5, 2013

A bunch of ways to highlight boost phrase matches over general term matches in score order highlighted fragments don't work. I don't have time to make a curl recreation at the moment but I'll send a pull request with failing tests that I think should all pass. Note: they all pass for the postings highlighter, but the other two don't have it together.

@nik9000

This comment has been minimized.

Show comment
Hide comment
@nik9000

nik9000 Dec 5, 2013

Contributor

I'll have a look at getting these to not fail at some point....

Contributor

nik9000 commented Dec 5, 2013

I'll have a look at getting these to not fail at some point....

@ghost ghost assigned jpountz Jan 4, 2014

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Jan 7, 2014

Stop FVH from throwing away some query boosts
The FVH was throwing away some boosts on queries stopping a number of
ways to boost phrase matches to the top of the list of fragments from
working.

The plain highlighter also doesn't work for this but that is because it
doesn't support the concept of the same term having a different score at
different positions.

Also update documentation claiming that FHV is nicer for weighing terms
found by query combinations.

Closes elastic#4351

@jpountz jpountz closed this in 8bd9e34 Jan 8, 2014

jpountz added a commit that referenced this issue Jan 8, 2014

Stop FVH from throwing away some query boosts
The FVH was throwing away some boosts on queries stopping a number of
ways to boost phrase matches to the top of the list of fragments from
working.

The plain highlighter also doesn't work for this but that is because it
doesn't support the concept of the same term having a different score at
different positions.

Also update documentation claiming that FHV is nicer for weighing terms
found by query combinations.

Closes #4351

brusic added a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014

Stop FVH from throwing away some query boosts
The FVH was throwing away some boosts on queries stopping a number of
ways to boost phrase matches to the top of the list of fragments from
working.

The plain highlighter also doesn't work for this but that is because it
doesn't support the concept of the same term having a different score at
different positions.

Also update documentation claiming that FHV is nicer for weighing terms
found by query combinations.

Closes elastic#4351

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Stop FVH from throwing away some query boosts
The FVH was throwing away some boosts on queries stopping a number of
ways to boost phrase matches to the top of the list of fragments from
working.

The plain highlighter also doesn't work for this but that is because it
doesn't support the concept of the same term having a different score at
different positions.

Also update documentation claiming that FHV is nicer for weighing terms
found by query combinations.

Closes elastic#4351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment