Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify keystore format in breaking changes 7.0 #43835

Closed
gemaliano opened this issue Jul 1, 2019 · 1 comment · Fixed by #45222
Closed

[DOCS] Clarify keystore format in breaking changes 7.0 #43835

gemaliano opened this issue Jul 1, 2019 · 1 comment · Fixed by #45222

Comments

@gemaliano
Copy link
Contributor

Reading breaking changes it is clear we have to use keystore.

It would be good to add clarification regarding keystore format.

Before 7.0 we could have setting in elasticsearch.yml
xpack.notification.pagerduty.account.TEST.service_api_key

In 7.0 we will need
xpack.notification.pagerduty.account.TEST.secure_service_api_key

However this format is not valid when adding to keystore (bin/elasticsearch-keystore add xpack.notification.pagerduty.account.TEST.secure_service_api_key) we get:
ERROR: Setting name [xpack.notification.pagerduty.account.TEST.secure_service_api_key] does not match the allowed setting name pattern [[a-z0-9_\-.]+]

In this case account format in elasticsearch.yml will have to change as well.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

rjernst pushed a commit that referenced this issue Aug 17, 2019
The elasticsearch keystore was originally backed by a PKCS#12 keystore, which had several limitations. To overcome some of these limitations in encoding, the setting names existing within the keystore were limited to lowercase alphanumberic (with underscore). Now that the keystore is backed by an encrypted blob, this restriction is no longer relevant. This commit relaxes that restriction by allowing uppercase ascii characters as well.

closes #43835
rjernst pushed a commit that referenced this issue Aug 17, 2019
The elasticsearch keystore was originally backed by a PKCS#12 keystore, which had several limitations. To overcome some of these limitations in encoding, the setting names existing within the keystore were limited to lowercase alphanumberic (with underscore). Now that the keystore is backed by an encrypted blob, this restriction is no longer relevant. This commit relaxes that restriction by allowing uppercase ascii characters as well.

closes #43835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants