New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing else? #4390

Closed
twinforces opened this Issue Dec 10, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@twinforces

twinforces commented Dec 10, 2013

I think there should be an else here

I think there should be an else here. Otherwise the code inside the if is irrelevant, because the put outside the if will overwrite the results.

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Dec 10, 2013

Contributor

Makes sense - I will fix

Contributor

s1monw commented Dec 10, 2013

Makes sense - I will fix

@twinforces

This comment has been minimized.

Show comment
Hide comment
@twinforces

twinforces Dec 10, 2013

Thanks Simon! You Rock!

twinforces commented Dec 10, 2013

Thanks Simon! You Rock!

@ghost ghost assigned imotov and s1monw Dec 10, 2013

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment