New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RoutingNodes API #4458

Closed
s1monw opened this Issue Dec 16, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@s1monw
Contributor

s1monw commented Dec 16, 2013

Currently the RoutingNodes API allows modification of it's internal state outside of the class. We already have a pullrequest (#4257) that adds 10x performance improvements for shard allocation but it handles most of the state changes manually outside of RoutingNodes. We should make sure that the RoutingNodes is consistent at all time and encapsulate it's internal datastructures.

@ghost ghost assigned s1monw Dec 16, 2013

@kimchy

This comment has been minimized.

Show comment
Hide comment
@kimchy

kimchy Dec 16, 2013

Member

looks great!

Member

kimchy commented Dec 16, 2013

looks great!

s1monw added a commit that referenced this issue Dec 16, 2013

Improve RoutingNodes API
Currently the RoutingNodes API allows modification of it's internal state outside of the class.
This commit improves the APIs of `RoutingNode` and `RoutingNode` to change internal state
only within the classes itself.

Closes #4458

@s1monw s1monw closed this in 30c6f2f Dec 16, 2013

brusic added a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014

Improve RoutingNodes API
Currently the RoutingNodes API allows modification of it's internal state outside of the class.
This commit improves the APIs of `RoutingNode` and `RoutingNode` to change internal state
only within the classes itself.

Closes #4458

@s1monw s1monw added the resiliency label Jul 5, 2014

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Improve RoutingNodes API
Currently the RoutingNodes API allows modification of it's internal state outside of the class.
This commit improves the APIs of `RoutingNode` and `RoutingNode` to change internal state
only within the classes itself.

Closes #4458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment