New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - Expose headers on HttpRequest #4609

Closed
lmenezes opened this Issue Jan 3, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@lmenezes
Contributor

lmenezes commented Jan 3, 2014

There is a method available for retrieving the value of a header, but it's not possible to iterate over all headers.

Is there a reason why this is not exposed? If not, would be nice having that.

@lmenezes

This comment has been minimized.

Show comment
Hide comment
@lmenezes

lmenezes Jan 3, 2014

Contributor

btw, it would also be totally fine just exposing the list of header names.

Contributor

lmenezes commented Jan 3, 2014

btw, it would also be totally fine just exposing the list of header names.

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Jan 3, 2014

Contributor

do you wanna come up with a PR?

Contributor

s1monw commented Jan 3, 2014

do you wanna come up with a PR?

@lmenezes

This comment has been minimized.

Show comment
Hide comment
@lmenezes

lmenezes Jan 3, 2014

Contributor

sure. thanks :)

Contributor

lmenezes commented Jan 3, 2014

sure. thanks :)

@lmenezes

This comment has been minimized.

Show comment
Hide comment
@lmenezes

lmenezes Jan 6, 2014

Contributor

@s1monw I just created a wrapper for the headers. When pushing -f We lost part of the comments that were there.
I created the wrapper, deprecated the current getHeader and updated parts of the code that were using the deprecated method. Looks good now?

By the way, how do you usually work with updating a pull request like this? Just rebasing and push -f?

Contributor

lmenezes commented Jan 6, 2014

@s1monw I just created a wrapper for the headers. When pushing -f We lost part of the comments that were there.
I created the wrapper, deprecated the current getHeader and updated parts of the code that were using the deprecated method. Looks good now?

By the way, how do you usually work with updating a pull request like this? Just rebasing and push -f?

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Jan 6, 2014

Contributor

I think it looks good. Would you mind adding some javadocs to the new interface? I usually try to just stack up commits until we are good to go and then squash once everybody is happy.

Contributor

s1monw commented Jan 6, 2014

I think it looks good. Would you mind adding some javadocs to the new interface? I usually try to just stack up commits until we are good to go and then squash once everybody is happy.

@lmenezes

This comment has been minimized.

Show comment
Hide comment
@lmenezes

lmenezes Jan 6, 2014

Contributor

Javadocs done. Let me know if there is anything else.

Contributor

lmenezes commented Jan 6, 2014

Javadocs done. Let me know if there is anything else.

lmenezes added a commit to lmenezes/elasticsearch that referenced this issue Jan 6, 2014

@ghost ghost assigned s1monw Jan 8, 2014

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Jan 8, 2014

Contributor

pushed

Contributor

s1monw commented Jan 8, 2014

pushed

@s1monw s1monw closed this Jan 8, 2014

brusic added a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment