Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark 'lucene-expression' as 'provided' in pom.xml #4859

Closed
s1monw opened this issue Jan 23, 2014 · 3 comments

Comments

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

commented Jan 23, 2014

We currently pull in the lucene-expression module that is referenced by lucene-suggest. Yet, we don't make use of this dependency at all and it pulls in a bunch of unshaded libs like antlr and asm which are pretty common in other projects. We should exclude this dependency since we don't use it at all and it causes problems when Elasticsearch is used as a node client. (see #4858 )

If we mark the dependency as provided it won't be included in the distribution.

@kimchy

This comment has been minimized.

Copy link
Member

commented Jan 23, 2014

I think the main problem is when using elasticsearch as a embedded client jar, and then I agree, we should make sure its optional. I think that we will end up integrating with it though (as a script engine?), so it will be part of our full distribution eventually. I think provided will work then as well.

@s1monw

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2014

agreed

s1monw added a commit that referenced this issue Jan 23, 2014

Mark 'lucene-expression' as 'provided' in pom.xml
We currently pull in the lucene-expression module that is referenced
by lucene-suggest. Yet, we don't make use of this dependency at all
and it pulls in a bunch of unshaded libs like `antlr` and `asm` which
are pretty common in other projects. We should exclude this
dependency since we don't use it at all and it causes problems
when Elasticsearch is used as a node client. (see #4858)

If we mark the dependency as provided it won't be included in the
distribution.

Closes #4859
Closes #4858

s1monw added a commit that referenced this issue Jan 23, 2014

Mark 'lucene-expression' as 'provided' in pom.xml
We currently pull in the lucene-expression module that is referenced
by lucene-suggest. Yet, we don't make use of this dependency at all
and it pulls in a bunch of unshaded libs like `antlr` and `asm` which
are pretty common in other projects. We should exclude this
dependency since we don't use it at all and it causes problems
when Elasticsearch is used as a node client. (see #4858)

If we mark the dependency as provided it won't be included in the
distribution.

Closes #4859
Closes #4858

@s1monw s1monw closed this in 416e328 Jan 23, 2014

s1monw added a commit that referenced this issue Jan 23, 2014

Mark 'lucene-expression' as 'provided' in pom.xml
We currently pull in the lucene-expression module that is referenced
by lucene-suggest. Yet, we don't make use of this dependency at all
and it pulls in a bunch of unshaded libs like `antlr` and `asm` which
are pretty common in other projects. We should exclude this
dependency since we don't use it at all and it causes problems
when Elasticsearch is used as a node client. (see #4858)

If we mark the dependency as provided it won't be included in the
distribution.

Closes #4859
Closes #4858
@CodingFabian

This comment has been minimized.

Copy link

commented Jan 27, 2014

Just an idea: Why not make a elasticsearch-client artifact which does only contain dependencies needed for client only nodes? Would that still require all those lucene dependencies?

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Mark 'lucene-expression' as 'provided' in pom.xml
We currently pull in the lucene-expression module that is referenced
by lucene-suggest. Yet, we don't make use of this dependency at all
and it pulls in a bunch of unshaded libs like `antlr` and `asm` which
are pretty common in other projects. We should exclude this
dependency since we don't use it at all and it causes problems
when Elasticsearch is used as a node client. (see elastic#4858)

If we mark the dependency as provided it won't be included in the
distribution.

Closes elastic#4859
Closes elastic#4858

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Mark 'lucene-expression' as 'provided' in pom.xml
We currently pull in the lucene-expression module that is referenced
by lucene-suggest. Yet, we don't make use of this dependency at all
and it pulls in a bunch of unshaded libs like `antlr` and `asm` which
are pretty common in other projects. We should exclude this
dependency since we don't use it at all and it causes problems
when Elasticsearch is used as a node client. (see elastic#4858)

If we mark the dependency as provided it won't be included in the
distribution.

Closes elastic#4859
Closes elastic#4858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.