Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query_string and simple_query_string should allow selective a Locale #5128

Closed
dakrone opened this Issue Feb 14, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@dakrone
Copy link
Member

commented Feb 14, 2014

query_string currently defaults to Locale.getDefault() while simple_query_string uses Locale.ROOT.

We should add a "locale" option to both queries that allows the user to select a locale, and unify the defaults to be the same.

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2014

+1

@dakrone

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2014

@s1monw what do you think the default should be? Locale.getDefault() or Locale.ROOT?

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2014

IMO it should be ROOT so it's consistent whereever you use it and then it can be change via the request if you like to

@dakrone dakrone self-assigned this Feb 14, 2014

@dakrone dakrone added v1.1.0 labels Feb 14, 2014

dakrone added a commit to dakrone/elasticsearch that referenced this issue Feb 20, 2014

Add "locale" parameter to query_string and simple_query_string
Fixes elastic#5128

Remove java 7 specific Locale functions, add "coming[1.1.0]" to documentation

add LocaleUtils utility class for dealing with Locale functions

dakrone added a commit that referenced this issue Feb 20, 2014

Add "locale" parameter to query_string and simple_query_string
Fixes #5128

Remove java 7 specific Locale functions, add "coming[1.1.0]" to documentation

add LocaleUtils utility class for dealing with Locale functions

@dakrone dakrone closed this in 8f8cc72 Feb 20, 2014

colings86 added a commit to colings86/elasticsearch that referenced this issue Sep 12, 2014

Geo: Fixes BoundingBox across complete longitudinal range
Adds a special case to the GeoBoundingBoxFilterParser so that the left of the box is not normalised in the case where left and right are 360 apart.  Before this change the left would be normalised to 180 in this case and the filter would only match points with a longitude of 180 (or -180).

Closes elastic#5128

colings86 added a commit that referenced this issue Sep 12, 2014

Geo: Fixes BoundingBox across complete longitudinal range
Adds a special case to the GeoBoundingBoxFilterParser so that the left of the box is not normalised in the case where left and right are 360 apart.  Before this change the left would be normalised to 180 in this case and the filter would only match points with a longitude of 180 (or -180).

Closes #5128

colings86 added a commit that referenced this issue Sep 12, 2014

Geo: Fixes BoundingBox across complete longitudinal range
Adds a special case to the GeoBoundingBoxFilterParser so that the left of the box is not normalised in the case where left and right are 360 apart.  Before this change the left would be normalised to 180 in this case and the filter would only match points with a longitude of 180 (or -180).

Closes #5128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.