Always use deprecateAndMaybeLog for deprecation warnings #55115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#53137. Replace calls to `deprecate(String,Object...)` with `deprecateAndMaybeLog(...)`, with an appropriate key, so that all messages can potentially be deduplicated.
pugnascotia
added
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
rjernst
approved these changes
Apr 13, 2020
qa/evil-tests/src/test/java/org/elasticsearch/common/logging/EvilLoggerTests.java
Outdated
Show resolved
Hide resolved
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Apr 16, 2020
Backport of elastic#55115. Closes elastic#53137. Replace calls to deprecate(String,Object...) with deprecateAndMaybeLog(...), with an appropriate key, so that all messages can potentially be deduplicated.
yyff
pushed a commit
to yyff/elasticsearch
that referenced
this pull request
Apr 17, 2020
Closes elastic#53137. Replace calls to deprecate(String,Object...) with deprecateAndMaybeLog(...), with an appropriate key, so that all messages can potentially be deduplicated.
pugnascotia
added a commit
that referenced
this pull request
Apr 23, 2020
Backport of #55115. Replace calls to deprecate(String,Object...) with deprecateAndMaybeLog(...), with an appropriate key, so that all messages can potentially be deduplicated.
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Mar 5, 2021
The commit elastic#55115 removed the possibility to directly force deprecation log to be emitted. This means that usage of deprecated fields was throtthled and only one deprecation was logged. The key was common for all fields = "deprecated_field". This commit appends a used deprecated field name to prevent that throthling.
pgomulka
added a commit
that referenced
this pull request
Mar 5, 2021
The commit #55115 removed the possibility to directly force deprecation log to be emitted. This means that usage of deprecated fields was throttled and only one deprecation was logged. The key was common for all fields = "deprecated_field". This commit appends a used deprecated field name to prevent that throttled.
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Mar 5, 2021
The commit elastic#55115 removed the possibility to directly force deprecation log to be emitted. This means that usage of deprecated fields was throttled and only one deprecation was logged. The key was common for all fields = "deprecated_field". This commit appends a used deprecated field name to prevent that throttled.
pgomulka
added a commit
that referenced
this pull request
Mar 9, 2021
The commit #55115 removed the possibility to directly force deprecation log to be emitted. This means that usage of deprecated fields was throttled and only one deprecation was logged. The key was common for all fields = "deprecated_field". This commit appends a used deprecated field name to prevent that throttled.
easyice
pushed a commit
to easyice/elasticsearch
that referenced
this pull request
Mar 25, 2021
The commit elastic#55115 removed the possibility to directly force deprecation log to be emitted. This means that usage of deprecated fields was throttled and only one deprecation was logged. The key was common for all fields = "deprecated_field". This commit appends a used deprecated field name to prevent that throttled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53137. Replace calls to
deprecate(String,Object...)withdeprecateAndMaybeLog(...), with an appropriate key, so that all messages can potentially be deduplicated.