Validate alias operations don't target data streams #58327
Conversation
This adds validation to make sure alias operations (add, remove, remove index) don't target data streams or the backing indices.
andreidan
added
v8.0.0
:Data Management/Data streams
|
Pinging @elastic/es-core-features (:Core/Features/Data streams) |
elasticmachine
added
the
Team:Data Management
| if (indexAbstraction.getParentDataStream() != null) { | ||
| throw new IllegalArgumentException("The provided index [ " + action.getIndex() | ||
| + "] is a backing index belonging to data stream [" + indexAbstraction.getParentDataStream().getName() | ||
| + "]. data streams and their backing indices don't support aliases driven operations."); |
There was a problem hiding this comment.
Minor error message suggestion -- I think "aliases driven operations" should be either "alias-driven operations" or just "alias operations." I prefer the latter as it's simple and clear.
| if (indexAbstraction.getParentDataStream() != null) { | ||
| throw new IllegalArgumentException("The provided expressions [" + String.join(",", action.indices()) | ||
| + "] match a backing index belonging to data stream [" + indexAbstraction.getParentDataStream().getName() | ||
| + "]. data streams and their backing indices don't support aliases."); |
There was a problem hiding this comment.
Minor: We're inconsistent across the codebase in whether we capitalize our error messages, but I think we should be consistent within a single error message. In other words, either make "The provided..." lowercase or capitalize the second sentence:
| + "]. data streams and their backing indices don't support aliases."); | |
| + "]. Data streams and their backing indices don't support aliases."); |
| if (indexAbstraction.getParentDataStream() != null) { | ||
| throw new IllegalArgumentException("The provided index [ " + action.getIndex() | ||
| + "] is a backing index belonging to data stream [" + indexAbstraction.getParentDataStream().getName() | ||
| + "]. data streams and their backing indices don't support aliases driven operations."); |
There was a problem hiding this comment.
Same thing about capitalization here.
|
Also, shouldn't this work prevent attempts to assign an alias to a data stream itself and not just its backing indices? |
@danhermann We do fail when we target data streams. I've updated the The |
This adds validation to make sure alias operations (add, remove, remove index) don't target data streams or the backing indices. (cherry picked from commit 8164489) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This adds validation to make sure alias operations (add, remove, remove index)
don't target data streams or the backing indices.
Relates to #53100