Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConcurrentMergeSchedulerProvider should use Lucene's default settings #5882

Closed
mikemccand opened this issue Apr 19, 2014 · 3 comments
Closed

ConcurrentMergeSchedulerProvider should use Lucene's default settings #5882

mikemccand opened this issue Apr 19, 2014 · 3 comments
Assignees
@mikemccand
Labels
>enhancement v1.2.0 v2.0.0-beta1

Comments

@mikemccand
Copy link
Contributor

In https://issues.apache.org/jira/browse/LUCENE-4661 we changed CMS's default maxMergeCount / maxMergeThreads to be less aggressive because the previous settings (allowing too many concurrent merges) would make merging less efficient.

But Elasticsearch's ConcurrentMergeSchedulerProvider is still using the old defaults.

I think we should just cutover to using whatever Lucene defaults to?
@mikemccand mikemccand self-assigned this Apr 19, 2014
@s1monw
Copy link
Contributor

s1monw commented Apr 19, 2014

+1

mikemccand added a commit to mikemccand/elasticsearch that referenced this issue Apr 22, 2014
@mikemccand
elastic#5882 use Lucene's defaults for CMS settings
7cee761
This was referenced Apr 22, 2014
Closed
Closed
mikemccand added a commit to mikemccand/elasticsearch that referenced this issue Apr 22, 2014
@mikemccand
elastic#5882 keep the CMS settings configurable; just change the defa…
6ce7153 
…ults to Lucene's
mikemccand added a commit that referenced this issue Apr 23, 2014
@mikemccand
Closes #5882
8501a6c
mikemccand added a commit to mikemccand/elasticsearch that referenced this issue Apr 24, 2014
@mikemccand
Closes elastic#5882
598420f
@rmuir rmuir mentioned this issue May 7, 2014
Closed
@mikemccand
Copy link
Contributor Author

We are changing a lot of merge / indexing throttling issues in 1.2; I think to be more conservative we should put back ES's original defaults here.

@mikemccand mikemccand reopened this May 12, 2014
@mikemccand
Copy link
Contributor Author

OK I restored the original ES defaults for 1.2/2.0.

mikemccand added a commit that referenced this issue May 12, 2014
@mikemccand
#5882: fix docs
b6ae7fb
mikemccand added a commit that referenced this issue May 12, 2014
@mikemccand
#5882: fix docs
b674ab5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemccand mikemccand

Labels
>enhancement v1.2.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikemccand @s1monw