Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InternalIndexShard callback handling of failure is missing/wrong #5945

Closed
kimchy opened this issue Apr 25, 2014 · 0 comments
Closed

InternalIndexShard callback handling of failure is missing/wrong #5945

kimchy opened this issue Apr 25, 2014 · 0 comments
Assignees
@GaelTadh
Labels
>bug good first issue low hanging fruit

Comments

@kimchy
Copy link
Member

kimchy commented Apr 25, 2014

In InternalIndexShard#index method calls failedIndex callback (to reduce current counters) when a RuntimeException happens, it should do it for any Throwable. Also, we are missing similar logic in create, and we should properly handle delete as well.

Might make sense to have a single post callback, and not post/failed, with an Throwable passed to indicate if it was a failure or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GaelTadh GaelTadh

Labels
>bug good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes InternalIndexShard callback handling of failure
2 participants
@kimchy @GaelTadh