Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Support empty fields array in mappings #6133
In order to be on the safe side. I was thinking about creating a few unit tests.
Which currently is
Any tips about what is the proper way on ElasticSearch to test this without having to use a real ParserContext (which has a massive constructor param list)? Mocking doens't look like an option as I couldn't find a framework for that on the deps.
@cfontes ++ for tests. Have a look at the test that was added to the related issue: https://github.com/elasticsearch/elasticsearch/pull/6006/files#diff-9a44deb15da4051f9980d8d6889d1684R56
Sorry for the delay.
@clintongormley thanks for the tip, it helped a lot.
So I ran the whole test suite 2x (took 40 minutes each!) 2 tests failed, but one is a @badapple and the other one is marked as @LuceneTestCase.AwaitsFix
Tests with failures:
Is it ok to send the pull like that? I cannot run it again. It just takes to long and locks my machine.
Are they both @badapples or the second is my fault?