Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failure member in ShardSearchFailure is never serialized #6837

Closed
rjernst opened this Issue Jul 11, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@rjernst
Copy link
Member

commented Jul 11, 2014

The Throwable failure member of ShardSearchFailure is taken on construction, but only used to generate a detailed error message to place in the reason member. It is never serialized/deserialized. But there is a failure() function that returns the Throwable. In the case of a transported failure, it is always null.

I think we should just remove failure (it is only set in one of the many constructors), and in the two tests that use it, use reason instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.