Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregations: Better shard_size default for terms aggregation #6857

Closed
colings86 opened this Issue Jul 14, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@colings86
Copy link
Member

colings86 commented Jul 14, 2014

For the Terms Aggregation the shardSize currently defaults to size. This is not a particularly good default value and also is not inline with the defaults set by the significant terms and geohash grid aggregaitons. We should change the defaults for the terms aggregation to use BucketUtils.suggestShardSideQueueSize() to be consistent and provide a more useful default

@colings86 colings86 self-assigned this Jul 14, 2014

@colings86 colings86 closed this in dc9e9cb Jul 24, 2014

colings86 added a commit that referenced this issue Jul 24, 2014

Aggregations: change to default shard_size in terms aggregation
The default shard size in the terms aggregation now uses BucketUtils.suggestShardSideQueueSize() to set the shard size if the user does not specify it as a parameter.

Closes #6857

@colings86 colings86 changed the title Make Terms Aggregation use BucketUtils.suggestShardSideQueueSize() Aggregations: Better shard_size default for terms aggregation Jul 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.