Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Remove unsafe unaligned memory access - illegal on SPARC #6962

Closed
jpountz opened this Issue Jul 22, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@jpountz
Copy link
Contributor

jpountz commented Jul 22, 2014

Unaligned memory access is illegal on several architectures (such as SPARC, see https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/elasticsearch/Nh-kXI5J6Ek/WXIZKhhGVHkJ for context).

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 22, 2014

oh boy

jpountz added a commit to jpountz/elasticsearch that referenced this issue Jul 22, 2014

Core: Drop UnsafeUtils.
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close elastic#6962

@jpountz jpountz changed the title Remove unsafe unaligned memory access Core: Remove unsafe unaligned memory access Jul 23, 2014

jpountz added a commit that referenced this issue Jul 23, 2014

Core: Drop UnsafeUtils.
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close #6962

@jpountz jpountz added v2.0.0 labels Jul 23, 2014

@jpountz jpountz closed this in 08f8731 Jul 23, 2014

@s1monw s1monw added v1.2.3 labels Jul 23, 2014

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jul 23, 2014

I added the labels for 1.3 and 1.2.3 this is basically making us not portable anymore and we should fix that! you should also remove the pom.xml entry that makes the unsafe utils and exception for forbidden APIs

@clintongormley clintongormley changed the title Core: Remove unsafe unaligned memory access Internal: Remove unsafe unaligned memory access - illegal on SPARC Jul 23, 2014

jpountz added a commit that referenced this issue Jul 23, 2014

Core: Drop UnsafeUtils.
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close #6962

jpountz added a commit that referenced this issue Jul 23, 2014

Core: Drop UnsafeUtils.
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close #6962
@jprante

This comment has been minimized.

Copy link
Contributor

jprante commented Oct 20, 2014

ES 1.3.4 still has issues, but this time in lzf compression codec. See file hs_err_pid26623.log at
https://gist.github.com/jprante/3c9ca8a85da13bd65226

@rjernst

This comment has been minimized.

Copy link
Member

rjernst commented Oct 20, 2014

@jprante The fix to remove unsafe usage in lzf compression was backported to 1.3.5 in #8078

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Core: Drop UnsafeUtils.
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close elastic#6962

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Core: Drop UnsafeUtils.
This class potentially does unaligned memory access and does not bring much
now that we switched to global ords for terms aggregations.

Close elastic#6962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.