Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregations: Geo bounds aggregation does not output aggregation name #7004

Closed
colings86 opened this Issue Jul 24, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@colings86
Copy link
Member

commented Jul 24, 2014

The geo bounds aggregation does not surround its JSON output with the aggregation name. For 1.3.x this should be fixed directly. For 1.4+ we should move the serialisation of the aggregation name to InternalAggregation so an aggregation can only output JSON in its own scope.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2014

+1

@colings86 colings86 added bug labels Jul 24, 2014

@colings86 colings86 closed this in fdf2bb9 Jul 24, 2014

colings86 added a commit that referenced this issue Jul 24, 2014

Aggregations: Better JSON output scoping
Before this change each aggregation had to output an object field with its name and write its JSON inside that object.  This allowed for badly behaved aggregations which could write JSON content in the root of the 'aggs' object.  this change move the writing of the aggregation name to a level above the aggregation itself, ensuring that aggregations can only write within there own scope in the JSON output.

Closes #7004

colings86 added a commit to colings86/elasticsearch that referenced this issue Jul 24, 2014

Aggregations: Fix JSON output of geo bounds aggregation
The geo bounds aggregation was not outputting the aggregation name and in the case where there was no data would output malformed JSON (extra } )

CLoses elastic#7004

colings86 added a commit that referenced this issue Jul 24, 2014

Aggregations: Fix JSON output of geo bounds aggregation
The geo bounds aggregation was not outputting the aggregation name and in the case where there was no data would output malformed JSON (extra } )

CLoses #7004

olivere added a commit to olivere/elastic that referenced this issue Jul 26, 2014

aggs: add geo_bounds aggregation
Notice: Elasticsearch 1.3.0 has an error here in that it does not
output the aggregation name. So tests should fail with 1.3.0.
It is fixed in
elastic/elasticsearch#7004.

@clintongormley clintongormley changed the title Geo bounds aggregation does not output aggregation name Aggregations: Geo bounds aggregation does not output aggregation name Jul 28, 2014

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Aggregations: Fix JSON output of geo bounds aggregation
The geo bounds aggregation was not outputting the aggregation name and in the case where there was no data would output malformed JSON (extra } )

CLoses elastic#7004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.