Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java filtered query requires query #7365

Closed
brackxm opened this Issue Aug 21, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@brackxm
Copy link
Contributor

brackxm commented Aug 21, 2014

queryBuilder is not Nullable in FilteredQueryBuilder.
Using json/http it is optional.
Example in the documentation:
http://www.elasticsearch.org/guide/en/elasticsearch/guide/current/_filtering_queries_and_aggregations.html

The workaround is to use a matchAllQuery.

@jpountz jpountz added v2.0.0 labels Aug 21, 2014

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 21, 2014

Thanks for the report, this looks wrong indeed.

@jpountz jpountz added the adoptme label Aug 21, 2014

@brackxm

This comment has been minimized.

Copy link
Contributor Author

brackxm commented Aug 21, 2014

Is there a performance difference between a matchAllQuery and no query?

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Aug 21, 2014

No. Actually the parser uses a match_all query when no query is specified, so this is mostly equivalent, the only thing that you pay for is the serialization of the match_all query, but that should be nothing.

@brackxm

This comment has been minimized.

Copy link
Contributor Author

brackxm commented Aug 22, 2014

not sure how adoptme is supposed to work, but i'll have a go

@clintongormley

This comment has been minimized.

Copy link
Member

clintongormley commented Aug 22, 2014

@brackxm great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.