Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java API improvement: Factory methods for SuggestionBuilders #7435

Closed
gquintana opened this Issue Aug 25, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@gquintana
Copy link

gquintana commented Aug 25, 2014

Introduce a static factory class SuggestionBuilders (like QueryBuilders, FilterBuilders), containing static method to create SuggestionBuilder instances.

SuggestBuilder class:

  • has termSuggestion and phraseSuggestion factory methods
  • hasn't completionSuggestion nor fuzzyCompletionSuggestion
@areek

This comment has been minimized.

Copy link
Contributor

areek commented Aug 26, 2014

+1 for static factory for completionSuggester and co, I was thinking about adding this a few days ago.

@clintongormley clintongormley added feature and removed discuss labels Aug 26, 2014

@areek areek added v1.4.0 labels Aug 28, 2014

areek added a commit to areek/elasticsearch that referenced this issue Sep 1, 2014

Improved Suggest Client API:
- Added SuggestBuilders (analogous to QueryBuilders)
 - supporting term, phrase, completion and fuzzyCompletion suggestion builders
- Added suggest(SuggestionBuilder) to SuggestRequest
   - previously only suggest(BytesReference) was supported

closes elastic#7435

@areek areek closed this in #7507 Sep 1, 2014

areek added a commit that referenced this issue Sep 1, 2014

Improved Suggest Client API:
- Added SuggestBuilders (analogous to QueryBuilders)
 - supporting term, phrase, completion and fuzzyCompletion suggestion builders
- Added suggest(SuggestionBuilder) to SuggestRequest
   - previously only suggest(BytesReference) was supported

closes #7435

areek added a commit that referenced this issue Sep 8, 2014

Improved Suggest Client API:
- Added SuggestBuilders (analogous to QueryBuilders)
 - supporting term, phrase, completion and fuzzyCompletion suggestion builders
- Added suggest(SuggestionBuilder) to SuggestRequest
   - previously only suggest(BytesReference) was supported

closes #7435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.