Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java api: get indexed script support for routing is incomplete #7559

Closed
javanna opened this Issue Sep 3, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@javanna
Copy link
Member

javanna commented Sep 3, 2014

GetIndexedScriptRequest supports setting a routing value, which never gets serialized over the transport though nor read when converting the request to the internal get one, also the correspoinding write operations PutIndexedScriptRequest and DeleteIndexedScriptRequest don't support it, thus it makes no sense to support it when reading.

Question is: does it make sense to support routing here or shall we remove the support for it as it never worked?

@javanna javanna added bug labels Sep 3, 2014

@javanna javanna self-assigned this Sep 3, 2014

@javanna javanna changed the title Java api: get indexed script supports for routing is incomplete Java api: get indexed script support for routing is incomplete Sep 3, 2014

@javanna javanna assigned GaelTadh and unassigned javanna Sep 3, 2014

@clintongormley

This comment has been minimized.

Copy link
Member

clintongormley commented Sep 6, 2014

Given that the index is a single shard as of #7500, it seems that routing isn't required. (Unless users can change these settings?)

@javanna

This comment has been minimized.

Copy link
Member Author

javanna commented Sep 9, 2014

Right I would just remove any mention of routing around get indexed script api then.

@clintongormley clintongormley added v1.5.0 and removed v1.4.0.Beta1 labels Sep 11, 2014

GaelTadh added a commit to GaelTadh/elasticsearch that referenced this issue Sep 19, 2014

Indexed Scripts/Templates : Cleanup
This contains several cleanups to the indexed scripts.
Remove the unused FetchSourceContext from the Get request..
Add lang,_version,_id to the REST GET API.
Removes the routing from GetIndexedScriptRequest since the script index is a single shard that is replicated across all nodes.
Fix backward compatible template file reference
Before 1.3.0 on disk scripts could be referenced by requesting
````
_search/template

{
  "template" : "ondiskscript"
}
````
This was broken in 1.3.0 by requiring
````
{
  "template" :
  {
    "file" : "ondiskscript"
  }
}
````
This commit restores the previous behavior.
Remove support for preference, realtime and refresh
These parameters don't make sense anymore for indexed scripts as we always force the preference to _local and
always refresh after a Put to the indexed scripts index.

Closes elastic#7568
Closes elastic#7559
Closes elastic#7647
Closes elastic#7567

@GaelTadh GaelTadh closed this in 8e742c2 Sep 19, 2014

GaelTadh added a commit that referenced this issue Sep 19, 2014

Indexed Scripts/Templates : Cleanup
This contains several cleanups to the indexed scripts.
Remove the unused FetchSourceContext from the Get request..
Add lang,_version,_id to the REST GET API.
Removes the routing from GetIndexedScriptRequest since the script index is a single shard that is replicated across all nodes.
Fix backward compatible template file reference
Before 1.3.0 on disk scripts could be referenced by requesting
````
_search/template

{
  "template" : "ondiskscript"
}
````
This was broken in 1.3.0 by requiring
````
{
  "template" :
  {
    "file" : "ondiskscript"
  }
}
````
This commit restores the previous behavior.
Remove support for preference, realtime and refresh
These parameters don't make sense anymore for indexed scripts as we always force the preference to _local and
always refresh after a Put to the indexed scripts index.

Closes #7568
Closes #7559
Closes #7647
Closes #7567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.