Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java api: get indexed script support for preference, realtime and refresh is incomplete #7567

Closed
javanna opened this Issue Sep 3, 2014 · 1 comment

Comments

Projects
None yet
4 participants
@javanna
Copy link
Member

commented Sep 3, 2014

The get indexed script supports preference, realtime and refresh parameters. Those parameters can only be set through java api though, never parsed on the REST layer.

The set preference is also never used internally as we force the preference to _local all the time. Also, I wonder if realtime and refresh make sense since we always refresh internally after each write (put/delete indexed script).

My vote is for removing all three parameters from the java API.

@javanna javanna added bug labels Sep 3, 2014

@clintongormley clintongormley added v1.5.0 and removed v1.4.0.Beta1 labels Sep 8, 2014

GaelTadh added a commit to GaelTadh/elasticsearch that referenced this issue Sep 19, 2014

Indexed Scripts/Templates : Cleanup
This contains several cleanups to the indexed scripts.
Remove the unused FetchSourceContext from the Get request..
Add lang,_version,_id to the REST GET API.
Removes the routing from GetIndexedScriptRequest since the script index is a single shard that is replicated across all nodes.
Fix backward compatible template file reference
Before 1.3.0 on disk scripts could be referenced by requesting
````
_search/template

{
  "template" : "ondiskscript"
}
````
This was broken in 1.3.0 by requiring
````
{
  "template" :
  {
    "file" : "ondiskscript"
  }
}
````
This commit restores the previous behavior.
Remove support for preference, realtime and refresh
These parameters don't make sense anymore for indexed scripts as we always force the preference to _local and
always refresh after a Put to the indexed scripts index.

Closes elastic#7568
Closes elastic#7559
Closes elastic#7647
Closes elastic#7567

@GaelTadh GaelTadh closed this in 8e742c2 Sep 19, 2014

GaelTadh added a commit that referenced this issue Sep 19, 2014

Indexed Scripts/Templates : Cleanup
This contains several cleanups to the indexed scripts.
Remove the unused FetchSourceContext from the Get request..
Add lang,_version,_id to the REST GET API.
Removes the routing from GetIndexedScriptRequest since the script index is a single shard that is replicated across all nodes.
Fix backward compatible template file reference
Before 1.3.0 on disk scripts could be referenced by requesting
````
_search/template

{
  "template" : "ondiskscript"
}
````
This was broken in 1.3.0 by requiring
````
{
  "template" :
  {
    "file" : "ondiskscript"
  }
}
````
This commit restores the previous behavior.
Remove support for preference, realtime and refresh
These parameters don't make sense anymore for indexed scripts as we always force the preference to _local and
always refresh after a Put to the indexed scripts index.

Closes #7568
Closes #7559
Closes #7647
Closes #7567
@alaasamergit

This comment has been minimized.

Copy link

commented Sep 5, 2016

how can you set preference in Java api in the end ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.