Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Make `TransportMasterNodeOperationAction#checkBlock` abstract #7740

Closed
s1monw opened this Issue Sep 16, 2014 · 0 comments

Comments

Projects
None yet
2 participants
@s1monw
Copy link
Contributor

s1monw commented Sep 16, 2014

TransportMasterNodeOperationAction#checkBlock should be implemented by any subclasses of ``TransportMasterNodeOperationActionbut it's returningnull` by default. We should make that abstract to force implementations for it.

@kimchy kimchy closed this in b75d1d8 Sep 17, 2014

kimchy added a commit that referenced this issue Sep 17, 2014

Add missing cluster blocks handling for master operations
Master node related operations were missing proper handling of cluster blocks, allowing for example to perform cluster level update settings even before the state was fully restored on initial cluster startup

Note, the change allows to change read only related settings without checking for blocks on update settings, as without it, it means one can't re-enable metadata/write. Also, it doesn't check for blocks on cluster state and health API, as those are allowed to be used even when blocked to figure out what causes the block.
closes #7763
closes #7740

kimchy added a commit that referenced this issue Sep 17, 2014

Add missing cluster blocks handling for master operations
Master node related operations were missing proper handling of cluster blocks, allowing for example to perform cluster level update settings even before the state was fully restored on initial cluster startup

Note, the change allows to change read only related settings without checking for blocks on update settings, as without it, it means one can't re-enable metadata/write. Also, it doesn't check for blocks on cluster state and health API, as those are allowed to be used even when blocked to figure out what causes the block.
closes #7763
closes #7740

@clintongormley clintongormley changed the title [CORE] Make `TransportMasterNodeOperationAction#checkBlock` abstract Internal: Make `TransportMasterNodeOperationAction#checkBlock` abstract Sep 26, 2014

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Add missing cluster blocks handling for master operations
Master node related operations were missing proper handling of cluster blocks, allowing for example to perform cluster level update settings even before the state was fully restored on initial cluster startup

Note, the change allows to change read only related settings without checking for blocks on update settings, as without it, it means one can't re-enable metadata/write. Also, it doesn't check for blocks on cluster state and health API, as those are allowed to be used even when blocked to figure out what causes the block.
closes elastic#7763
closes elastic#7740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.