Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts in put mapping only reported for properties field #777

Closed
clintongormley opened this Issue Mar 12, 2011 · 0 comments

Comments

Projects
None yet
2 participants
@clintongormley
Copy link
Member

clintongormley commented Mar 12, 2011

When putting a mapping, if there is a conflict in properties, an exception is thrown. However, any conflicts in the other parameters ( eg _all, dynamic etc) are silently ignored.

These should also throw errors.

# [Sat Mar 12 19:38:18 2011] Protocol: http, Server: 127.0.0.1:9200
curl -XPUT 'http://127.0.0.1:9200/foo/' 

# [Sat Mar 12 19:38:18 2011] Response:
# {
#    "ok" : true,
#    "acknowledged" : true
# }

# [Sat Mar 12 19:38:21 2011] Protocol: http, Server: 127.0.0.1:9200
curl -XPUT 'http://127.0.0.1:9200/foo/bar/_mapping'  -d '
{
   "bar" : {
      "_all" : {
         "enabled" : 0
      },
      "dynamic" : 0,
      "properties" : {
         "text" : {
            "type" : "string"
         }
      }
   }
}
'

# [Sat Mar 12 19:38:21 2011] Response:
# {
#    "ok" : true,
#    "acknowledged" : true
# }

# [Sat Mar 12 19:38:24 2011] Protocol: http, Server: 127.0.0.1:9200
curl -XPUT 'http://127.0.0.1:9200/foo/bar/_mapping'  -d '
{
   "bar" : {
      "_all" : {
         "enabled" : 1
      },
      "dynamic" : 1,
      "properties" : {
         "text" : {
            "type" : "string"
         }
      }
   }
}
'

# [Sat Mar 12 19:38:24 2011] Response:
# {
#    "ok" : true,
#    "acknowledged" : true
# }

@clintongormley clintongormley added enhancement and removed adoptme labels Jul 3, 2014

brwe added a commit to brwe/elasticsearch that referenced this issue Aug 18, 2014

_ttl: Report conflict when trying to disable _ttl
_ttl could never be disabled once it was enabled.
But when trying to, no conflict was reported.

relates to elastic#777 and elastic#7293

brwe added a commit to brwe/elasticsearch that referenced this issue Aug 21, 2014

_all: report conflict on merge and throw exception on doc_values
- _all field was never merged when mapping was updated and no conflict reported
- _all accepted doc_values format although it is always tokenized

relates to elastic#777

brwe added a commit that referenced this issue Aug 21, 2014

_ttl: Report conflict when trying to disable _ttl
_ttl could never be disabled once it was enabled.
But when trying to, no conflict was reported.

relates to #777 and #7293

closes #7316

brwe added a commit that referenced this issue Aug 21, 2014

_ttl: Report conflict when trying to disable _ttl
_ttl could never be disabled once it was enabled.
But when trying to, no conflict was reported.

relates to #777 and #7293

closes #7316

brwe added a commit that referenced this issue Aug 26, 2014

_all: report conflict on merge and throw exception on doc_values
- _all field was never merged when mapping was updated and no conflict reported
- _all accepted doc_values format although it is always tokenized

relates to #777
closes #7377

brwe added a commit that referenced this issue Aug 26, 2014

_all: report conflict on merge and throw exception on doc_values
- _all field was never merged when mapping was updated and no conflict reported
- _all accepted doc_values format although it is always tokenized

relates to #777
closes #7377

brwe added a commit to brwe/elasticsearch that referenced this issue Sep 5, 2014

_timestamp: enable mapper properties merging
Updates on the _timestamp field were silently ignored.
Now _timestamp undergoes the same merge as regular
fields. This includes exceptions if a prroperty cannot
be changed.
"path" and "default" cannot be changed.

closes elastic#5772
closes elastic#6958
partially fixes elastic#777

@clintongormley clintongormley added v1.5.0 and removed v1.4.0.Beta1 labels Sep 8, 2014

@brwe brwe closed this in ee5221b Sep 8, 2014

brwe added a commit that referenced this issue Sep 8, 2014

_timestamp: enable mapper properties merging
Updates on the _timestamp field were silently ignored.
Now _timestamp undergoes the same merge as regular
fields. This includes exceptions if a property cannot
be changed.
"path" and "default" cannot be changed.

closes #5772
closes #6958
closes #7614
partially fixes #777

brwe added a commit that referenced this issue Sep 8, 2014

_ttl: Report conflict when trying to disable _ttl
_ttl could never be disabled once it was enabled.
But when trying to, no conflict was reported.

relates to #777 and #7293

closes #7316

brwe added a commit that referenced this issue Sep 8, 2014

_all: report conflict on merge and throw exception on doc_values
- _all field was never merged when mapping was updated and no conflict reported
- _all accepted doc_values format although it is always tokenized

relates to #777
closes #7377

@clintongormley clintongormley added v1.4.0.Beta1 and removed v1.5.0 labels Sep 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.