Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Use internal time estimation for time limited search collector #7833

Closed
s1monw opened this Issue Sep 23, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@s1monw
Copy link
Contributor

s1monw commented Sep 23, 2014

Today TimeLimitingCollector uses it's own thread to do time estimations for search request timeouts. This thread is not controllable via threadpools etc. we should use our own infrastructure to signal timeouts. Luckily we already have an estimating thread in the ThreadPool class we just need to expose it to the collector.

@s1monw s1monw self-assigned this Sep 23, 2014

s1monw added a commit that referenced this issue Sep 23, 2014

[TEST] Add a more restrictive thread leaks filter
Today all threads are allowed to leak a suite. This is tricky since
it essentially allows resource leaks by default where for instance
test private TransportClients will never get closed and consume
resources influencing other tests. It also hides threads that
are not fully under elasticsearchs control like the Lucene
TimeLimitingCollector thread. This commit restricts the threads
that can leak a suite to the threads spawned from testclusters
and fixes sevearl places that leaked threads.

Closes #7833

s1monw added a commit to s1monw/elasticsearch that referenced this issue Sep 23, 2014

[TEST] Add a more restrictive thread leaks filter
Today all threads are allowed to leak a suite. This is tricky since
it essentially allows resource leaks by default where for instance
test private TransportClients will never get closed and consume
resources influencing other tests. It also hides threads that
are not fully under elasticsearchs control like the Lucene
TimeLimitingCollector thread. This commit restricts the threads
that can leak a suite to the threads spawned from testclusters
and fixes sevearl places that leaked threads.

Closes elastic#7833

@s1monw s1monw closed this in 30acba6 Sep 23, 2014

@clintongormley clintongormley changed the title [SEARCH] Use internal time estimation for time limited collector Internal: Use internal time estimation for time limited search collector Sep 26, 2014

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

[TEST] Add a more restrictive thread leaks filter
Today all threads are allowed to leak a suite. This is tricky since
it essentially allows resource leaks by default where for instance
test private TransportClients will never get closed and consume
resources influencing other tests. It also hides threads that
are not fully under elasticsearchs control like the Lucene
TimeLimitingCollector thread. This commit restricts the threads
that can leak a suite to the threads spawned from testclusters
and fixes sevearl places that leaked threads.

Closes elastic#7833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.