Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregations: NPE in SignificanceHeuristicStreams.read while deserializing response #7840

Closed
markharwood opened this Issue Sep 23, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@markharwood
Copy link
Contributor

markharwood commented Sep 23, 2014

This is caused by the TransportClient failing to register a module that is now required to deserialize responses correctly.
The fix is to add this line to the constructor:

    modules.add(new SignificantTermsHeuristicModule());

Thanks to Felipe Hummel for reporting the error and providing a failing test case here: https://groups.google.com/forum/#!topic/elasticsearch/R42Nyyfr73I

@colings86

This comment has been minimized.

Copy link
Member

colings86 commented Sep 24, 2014

I think since the SignificantTermsHeuristicModule is just for use in the Aggregations we should make TransportAggregationModule implement SpawnModules and implement the spawnModules method as follows:

    @Override
    public Iterable<? extends Module> spawnModules() {
        return ImmutableList.of(new SignificantTermsHeuristicModule());
    }

@brwe brwe added the v1.3.3 label Sep 24, 2014

colings86 added a commit to colings86/elasticsearch that referenced this issue Sep 24, 2014

@colings86 colings86 changed the title NPE in SignificanceHeuristicStreams.read while deserializing response Aggregations: NPE in SignificanceHeuristicStreams.read while deserializing response Sep 24, 2014

colings86 added a commit that referenced this issue Sep 24, 2014

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.