New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be lenient when converting local to utc time in time zone roundings #10031

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@cbuescher
Member

cbuescher commented Mar 8, 2015

This solves a problem in the time zone rounding classes where time dates that
fall into a DST gap will cause joda time library to throw an exception.
Changing the conversion methods 'strict' option to false prevents this.

Closes #10025

cbuescher added some commits Mar 8, 2015

Aggregations: Be lenient when converting local to utc time in time zo…
…ne roundings

This solves a problem in the time zone rounding classes where time dates that
fall into a DST gap will cause joda time library to throw an exception.
Changing the conversion methods 'strict' option to false prevents this.

Closes #10025
@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Mar 16, 2015

Contributor

LGTM

Contributor

jpountz commented Mar 16, 2015

LGTM

@cbuescher cbuescher closed this Mar 16, 2015

@clintongormley clintongormley removed the review label Mar 19, 2015

@clintongormley clintongormley changed the title from Aggregations: Be lenient when converting local to utc time in time zone roundings to Be lenient when converting local to utc time in time zone roundings Jun 7, 2015

@cbuescher cbuescher deleted the cbuescher:fix/10025 branch Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment