Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rethrow already handled merge exceptions #10083

Closed
wants to merge 2 commits into from

Conversation

@mikemccand
Copy link
Contributor

commented Mar 13, 2015

ES already has a custom merge exception handler that 1) logs the exception and 2) fails the engine ... and then it calls super, which throws an unhandled exception, which I think is redundant. The JVM catches that and logs it again (to stderr), and this causes test failures like http://build-us-00.elastic.co/job/es_core_1x_centos/3701

I think we should remove the super call?

mikemccand added 2 commits Mar 13, 2015
mikemccand
mikemccand
@mikemccand

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2015

I also changed logger.warn to logger.error...

@dakrone

This comment has been minimized.

Copy link
Member

commented Mar 13, 2015

LGTM but @s1monw should probably look also

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2015

LGTM

mikemccand pushed a commit that referenced this pull request Mar 13, 2015
mikemccand
Core: don't rethrow merge exceptions
We already 1) log the full exception, and 2) fail the engine.

Closes #10083
mikemccand pushed a commit that referenced this pull request Mar 13, 2015
mikemccand
Core: deprecate delete-by-query
This API is trappy: it secretly does a refresh, which can quickly
cause too many segments / OOME if you are also concurrently indexing,
and it might delete different documents between primary and replica.

It will be removed in 2.0.

It's better to do a scan/scroll request with the query, gather the
matching ids, and issue a bulk request to delete them.

Closes #10083

@clintongormley clintongormley changed the title Core: don't rethrow already handled merge exceptions Don't rethrow already handled merge exceptions Jun 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.