Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: deprecate index.fail_on_merge_failure #10084

Closed
wants to merge 1 commit into from

Conversation

@mikemccand
Copy link
Contributor

commented Mar 13, 2015

When a merge exception happens I think we should always fail the engine, so I'd like to deprecate this setting in 1.5.0 and remove in 2.0.

@mikemccand mikemccand added the v1.5.0 label Mar 13, 2015
@mikemccand

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2015

I think we should also deprecate/remove fail_on_corruption? I.e. if corruption is detected we should always fail...

mikemccand pushed a commit that referenced this pull request Mar 14, 2015
In 2.0 we will always fail the engine on merge exception.

Closes #10084
@mikemccand mikemccand closed this Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.