New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove delete mapping API #10231
Remove delete mapping API #10231
Conversation
Can you add an entry to the migrate_2_0.asciidoc about the fact that this api has been deleted? Other than that LGTM. |
@martijnvg Sure, added a short message to the docs. |
LGTM |
1 similar comment
LGTM |
// all is well, the _river index was deleted | ||
} catch (Exception e) { | ||
logger.warn("unexpected failure when trying to verify river [{}] deleted", e, riverName.name()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what effect this change has on rivers... not sure...maybe next step would be to remove rivers code from master too? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimchy WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @javanna here. River plugins can't be used anymore as you can not remove a _river
instance.
To remove a _river
, we were doing:
DELETE _river/rivername
What can we do now?
FYI: this PR is the reason why we have all river plugins failing in Jenkins now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wrong. To remove a _river we should run:
DELETE _river/rivername/_meta
ping @spalger when this gets pushed you'll have to regenerate the api for the js client otherwise the references to the non existing docs page might break docs publish process. Thanks! |
LGTM too |
Deleting a type from an index is inherently dangerous because the type can be recreated with new mappings which may conflict with existing segments still using the old mappings. This removes the ability to delete a type (similar to how deleting fields within a type is not allowed, for the same reason). closes elastic#8877 closes elastic#10231
How to manage if an existing mapping is wrong? |
@aparo There are a number of reasons why reindexing is a better approach:
|
Deleting a type from an index is inherently dangerous because
the type can be recreated with new mappings which may conflict
with existing segments still using the old mappings. This
removes the ability to delete a type (similar to how deleting
fields within a type is not allowed, for the same reason).
closes #8877