New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 bugs in `children` agg #10263

Closed
wants to merge 2 commits into
base: 1.x
from

Conversation

Projects
None yet
3 participants
@martijnvg
Member

martijnvg commented Mar 25, 2015

PR for #10158

  1. Multiple nested children aggs result in a NPE. This only occurs in 1.x and not in master, since post collection works there in the correct order.
  2. Fixed a counting bug where the same readers where post collected twice. Possible fixes #9958

Note this PR is against 1.x b/c bug 1 is fixed in master already. This bug fix was part of a refactoring that happened as part of #9544

@jpountz

View changes

Show outdated Hide outdated ...arch/search/aggregations/bucket/children/ParentToChildrenAggregator.java
@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Mar 26, 2015

Contributor

LGTM

Contributor

jpountz commented Mar 26, 2015

LGTM

@martijnvg martijnvg removed the review label Mar 28, 2015

martijnvg added some commits Mar 24, 2015

inner_hits: Fix nested stored field support.
This also fixes a NPE when the nested part has been filtered out of the _source, because of _source filtering.

Closes #9766
aggs: Fix 2 bug in `children` agg
1) multiple nested children aggs result in a NPE
2) fixed a counting bug where the same readers where post collected twice

Closes #10158
@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg

martijnvg Mar 28, 2015

Member

pushed to master, 1.x and 1.5

Member

martijnvg commented Mar 28, 2015

pushed to master, 1.x and 1.5

@martijnvg martijnvg closed this Mar 28, 2015

@martijnvg martijnvg deleted the martijnvg:children_agg/broken_nested_usage_and_wrong_doc_counts branch May 18, 2015

@clintongormley clintongormley changed the title from children aggregation: Fix 2 bugs in `children` agg to Fix 2 bugs in `children` agg Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment