Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for `script.disable_dynamic` setting #10286

Closed

Conversation

@javanna
Copy link
Member

commented Mar 26, 2015

Now that fine-grained script settings are supported (#10116) we can remove support for the script.disable_dynamic setting, which is deprecated in our docs as of 1.6.0. Also, from 1.6.0 a deprecation warning will be printed out at startup in the logs whenever using the 'script.disable_dynamic param in elasticsearch.yml.

Note that the same result as script.disable_dynamic: false can be obtained as follows:

script.inline: on
script.indexed: on
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2015

we have to at least add this to docs/reference/migration/migrate_2_0.asciidoc or even throw an exception if somebody still uses this setting?

Now that fine-grained script settings are supported (#10116) we can remove support for the script.disable_dynamic setting.

Same result as `script.disable_dynamic: false` can be obtained as follows:

```
script.inline: on
script.indexed: on
```
@javanna javanna added the review label Mar 31, 2015
@javanna javanna force-pushed the javanna:enhancement/remove_disable_dynamic branch to 0b123f9 Mar 31, 2015
@javanna

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2015

good point @s1monw I addressed your comments

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2015

LGTM

@javanna javanna removed the review label Mar 31, 2015
@javanna javanna closed this in 83fb0a1 Mar 31, 2015
@mrsolo

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2015

Comment.

This is the current main branch behavior when encountering script.disable_dynamic and on.. pretty substantial log spam

2015-04-03 17:56:59,616][INFO ][node                     ] [Abomination] version[2.0.0-SNAPSHOT], pid[30537], build[d3b1567/2015-04-03T14:33:31Z]
[2015-04-03 17:56:59,616][INFO ][node                     ] [Abomination] initializing ...
[2015-04-03 17:56:59,619][INFO ][plugins                  ] [Abomination] loaded [], sites []
[2015-04-03 17:57:06,121][ERROR][bootstrap                ] Exception
org.elasticsearch.common.inject.CreationException: Guice creation errors:

1) Error injecting constructor, org.elasticsearch.ElasticsearchIllegalArgumentException: script.disable_dynamic is not a supported setting, replace with fine-grained script settings. 
Dynamic scripts can be enabled for all languages and all operations by replacing `script.disable_dynamic: false` with `script.inline: on` and `script.indexed: on` in elasticsearch.yml
  at org.elasticsearch.script.ScriptService.<init>(Unknown Source)
  while locating org.elasticsearch.script.ScriptService
Caused by: org.elasticsearch.ElasticsearchIllegalArgumentException: script.disable_dynamic is not a supported setting, replace with fine-grained script settings. 
Dynamic scripts can be enabled for all languages and all operations by replacing `script.disable_dynamic: false` with `script.inline: on` and `script.indexed: on` in elasticsearch.yml
    at org.elasticsearch.script.ScriptService.<init>(ScriptService.java:120)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
    at org.elasticsearch.common.inject.DefaultConstructionProxyFactory$1.newInstance(DefaultConstructionProxyFactory.java:56)
    at org.elasticsearch.common.inject.ConstructorInjector.construct(ConstructorInjector.java:86)
    at org.elasticsearch.common.inject.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:104)
    at org.elasticsearch.common.inject.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:47)
    at org.elasticsearch.common.inject.InjectorImpl.callInContext(InjectorImpl.java:865)
    at org.elasticsearch.common.inject.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:43)
    at org.elasticsearch.common.inject.Scopes$1$1.get(Scopes.java:59)
    at org.elasticsearch.common.inject.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:46)
    at org.elasticsearch.common.inject.InjectorBuilder$1.call(InjectorBuilder.java:201)
    at org.elasticsearch.common.inject.InjectorBuilder$1.call(InjectorBuilder.java:193)
    at org.elasticsearch.common.inject.InjectorImpl.callInContext(InjectorImpl.java:858)
    at org.elasticsearch.common.inject.InjectorBuilder.loadEagerSingletons(InjectorBuilder.java:193)
    at org.elasticsearch.common.inject.InjectorBuilder.injectDynamically(InjectorBuilder.java:175)
    at org.elasticsearch.common.inject.InjectorBuilder.build(InjectorBuilder.java:110)
    at org.elasticsearch.common.inject.Guice.createInjector(Guice.java:93)
    at org.elasticsearch.common.inject.Guice.createInjector(Guice.java:70)
    at org.elasticsearch.common.inject.ModulesBuilder.createInjector(ModulesBuilder.java:59)
    at org.elasticsearch.node.Node.<init>(Node.java:200)
    at org.elasticsearch.node.NodeBuilder.build(NodeBuilder.java:158)
    at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:66)
    at org.elasticsearch.bootstrap.Bootstrap.main(Bootstrap.java:200)
    at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:32)
mrsolo added a commit to elastic/ci that referenced this pull request Apr 3, 2015
@clintongormley clintongormley changed the title Scripting: remove support for script.disable_dynamic setting Remove support for `script.disable_dynamic` setting Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.