New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to launch bootstrapped ES using maven #10287

Merged
merged 1 commit into from Mar 30, 2015

Conversation

Projects
None yet
5 participants
@dakrone
Member

dakrone commented Mar 26, 2015

This adds the exec-maven-plugin that allows a developer to run:

mvn exec:exec

To launch the Bootstrap process similar to the way that a Java IDE
would. All the logs go to logs/elasticsearch.log (or wherever
configured)

@dakrone

This comment has been minimized.

Show comment
Hide comment
@dakrone

dakrone Mar 26, 2015

Member

This bumps into the (admittedly very low) ceiling of my Maven knowledge, so maybe @dadoonet can take a look?

Member

dakrone commented Mar 26, 2015

This bumps into the (admittedly very low) ceiling of my Maven knowledge, so maybe @dadoonet can take a look?

<argument>-XX:CMSInitiatingOccupancyFraction=75</argument>
<argument>-XX:+UseCMSInitiatingOccupancyOnly</argument>
<argument>-XX:+HeapDumpOnOutOfMemoryError</argument>
<argument>-XX:+DisableExplicitGC</argument>

This comment has been minimized.

@jpountz

jpountz Mar 26, 2015

Contributor

Since it will not be used for production maybe we don't need all the above parameters and could just rely on the default values of Xms/Xmx and garbage collection options? This would avoid having to maintain the list of JVM options here in addition to the bin/elasticsearch

@jpountz

jpountz Mar 26, 2015

Contributor

Since it will not be used for production maybe we don't need all the above parameters and could just rely on the default values of Xms/Xmx and garbage collection options? This would avoid having to maintain the list of JVM options here in addition to the bin/elasticsearch

This comment has been minimized.

@dakrone

dakrone Mar 28, 2015

Member

I don't know, I thought it would be better to have as close as possible to what users run with the defaults when running? Do we change them often enough to need to worry about having to maintain these?

@dakrone

dakrone Mar 28, 2015

Member

I don't know, I thought it would be better to have as close as possible to what users run with the defaults when running? Do we change them often enough to need to worry about having to maintain these?

This comment has been minimized.

@jpountz

jpountz Mar 30, 2015

Contributor

Good point, I don't think so.

@jpountz

jpountz Mar 30, 2015

Contributor

Good point, I don't think so.

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Mar 26, 2015

Contributor

This looks great! Maybe add a note about it to the README? This would definitely have helped me a lot when I started digging elasticsearch.

Contributor

jpountz commented Mar 26, 2015

This looks great! Maybe add a note about it to the README? This would definitely have helped me a lot when I started digging elasticsearch.

@javanna

View changes

Show outdated Hide outdated pom.xml
@dakrone

This comment has been minimized.

Show comment
Hide comment
@dakrone

dakrone Mar 30, 2015

Member

@jpountz added a note to TESTING.asciidoc (it seems to fit better there), thanks for the suggestion!

Member

dakrone commented Mar 30, 2015

@jpountz added a note to TESTING.asciidoc (it seems to fit better there), thanks for the suggestion!

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Mar 30, 2015

Contributor

LGTM. I see you tagged it with 1.5.1, I don't think this is required as this is a new feature?

Contributor

jpountz commented Mar 30, 2015

LGTM. I see you tagged it with 1.5.1, I don't think this is required as this is a new feature?

@dakrone dakrone removed the v1.5.1 label Mar 30, 2015

@dakrone

This comment has been minimized.

Show comment
Hide comment
@dakrone

dakrone Mar 30, 2015

Member

@jpountz whoops, you're right, removed that, thanks

Member

dakrone commented Mar 30, 2015

@jpountz whoops, you're right, removed that, thanks

Add ability to launch bootstrapped ES using maven
This adds the exec-maven-plugin that allows a developer to run:

```
mvn exec:exec
```

To launch the `Bootstrap` process similar to the way that a Java IDE
would. All the logs go to logs/elasticsearch.log (or wherever
configured)

@dakrone dakrone merged commit 1cb169a into elastic:master Mar 30, 2015

1 check passed

CLA Commit author has signed the CLA
Details

@dakrone dakrone deleted the dakrone:exec-plugin branch Apr 6, 2015

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Apr 17, 2015

Member

This exec phase does not exist in maven AFAIK.
I think we should remove this line, right? @dakrone WDYT?

Member

dadoonet commented on pom.xml in 1cb169a Apr 17, 2015

This exec phase does not exist in maven AFAIK.
I think we should remove this line, right? @dakrone WDYT?

This comment has been minimized.

Show comment
Hide comment
@dakrone

dakrone Apr 17, 2015

Member

@dadoonet the exec phase is part of this plugin (exec-maven-plugin)

Member

dakrone replied Apr 17, 2015

@dadoonet the exec phase is part of this plugin (exec-maven-plugin)

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Apr 17, 2015

Member

It's the goal. A Maven plugin can not define a new phase.

Member

dadoonet replied Apr 17, 2015

It's the goal. A Maven plugin can not define a new phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment