New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter for channel in NettyTransportChannel #10319

Merged
merged 1 commit into from Mar 30, 2015

Conversation

Projects
None yet
3 participants
@jaymode
Member

jaymode commented Mar 30, 2015

Adds a getter for the actual netty channel in NettyTransportChannel. The
channel can be used by plugins that need access into netty when processing
requests.

@s1monw

View changes

Show outdated Hide outdated src/main/java/org/elasticsearch/transport/netty/NettyTransportChannel.java
@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Mar 30, 2015

Contributor

LGTM - can you add a doc string

Contributor

s1monw commented Mar 30, 2015

LGTM - can you add a doc string

@jaymode

This comment has been minimized.

Show comment
Hide comment
@jaymode

jaymode Mar 30, 2015

Member

will add doc and push. thanks @s1monw

Member

jaymode commented Mar 30, 2015

will add doc and push. thanks @s1monw

@s1monw

This comment has been minimized.

Show comment
Hide comment
@s1monw

s1monw Mar 30, 2015

Contributor

thank you!

Contributor

s1monw commented Mar 30, 2015

thank you!

Netty: add getter for channel in NettyTransportChannel
Adds a getter for the actual netty channel in NettyTransportChannel. The
channel can be used by plugins that need access into netty when processing
requests.

@jaymode jaymode merged commit a2addaf into elastic:master Mar 30, 2015

1 check passed

CLA Commit author has signed the CLA
Details

@jaymode jaymode removed the review label Mar 30, 2015

@clintongormley clintongormley changed the title from Netty: add getter for channel in NettyTransportChannel to Add getter for channel in NettyTransportChannel Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment