New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from ScriptService #10476

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@javanna
Member

javanna commented Apr 8, 2015

Removed the following methods from ScriptService, which don't require the ScriptContext argument:

public CompiledScript compile(String lang,  String script, ScriptType scriptType)

public ExecutableScript executable(String lang, String script, ScriptType scriptType, Map<String, Object> vars)

public SearchScript search(SearchLookup lookup, String lang, String script, ScriptType scriptType, @Nullable Map<String, Object> vars)

Also removed the ScriptContext.Standard.GENERIC_PLUGIN enum value, as it was used only for backwards compatibility.

Plugins that make use of scripts should declare their own script contexts through ScriptModule#registerScriptContext and use them when compiling/executing scripts.

Scripting: remove deprecated methods from ScriptService
Removed the following methods from `ScriptService`, which don't require the `ScriptContext` argument:

```
public CompiledScript compile(String lang,  String script, ScriptType scriptType)

public ExecutableScript executable(String lang, String script, ScriptType scriptType, Map<String, Object> vars)

public SearchScript search(SearchLookup lookup, String lang, String script, ScriptType scriptType, @nullable Map<String, Object> vars)
```

Also removed the ScriptContext.Standard.GENERIC_PLUGIN enum value, as it was used only for backwards compatibility.

 Plugins that make use of scripts should declare their own script contexts through `ScriptModule#registerScriptContext` and use them when compiling/executing scripts.
@javanna

This comment has been minimized.

Show comment
Hide comment
@javanna

javanna Apr 8, 2015

Member

@uboness can you have a look please?

Member

javanna commented Apr 8, 2015

@uboness can you have a look please?

@uboness

This comment has been minimized.

Show comment
Hide comment
@uboness

uboness Apr 8, 2015

Contributor

LGTM

Contributor

uboness commented Apr 8, 2015

LGTM

@javanna javanna closed this in d9aebf4 Apr 8, 2015

@javanna javanna removed the review label Apr 8, 2015

@javanna

This comment has been minimized.

Show comment
Hide comment
@javanna

javanna Apr 8, 2015

Member

Note: this change is breaking only for plugins that make use of scripts.

Member

javanna commented Apr 8, 2015

Note: this change is breaking only for plugins that make use of scripts.

@clintongormley clintongormley changed the title from Scripting: remove deprecated methods from ScriptService to Remove deprecated methods from ScriptService Jun 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment