Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync translog before closing engine #10484

Merged
merged 1 commit into from Apr 8, 2015

Conversation

Projects
None yet
3 participants
@s1monw
Copy link
Contributor

s1monw commented Apr 8, 2015

If the translog is buffered we must make sure everything is synced to disk
before we rollback the writer otherwise we open a window for potential dataloss due
to stupid errors preventing the translog from being closed.

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Apr 8, 2015

@bleskes can you take a look?

@bleskes

This comment has been minimized.

Copy link
Member

bleskes commented Apr 8, 2015

LGTM. Can we change the title to sync translog when closing engine?

Also, to be clear - on normal shutdown we flush so this is mostly relevant to closing an index right?

@s1monw s1monw changed the title [ENGINE] flush translog before closing engine [ENGINE] sync translog before closing engine Apr 8, 2015

[ENGINE] sync translog before closing engine
If the translog is buffered we must make sure everything is synced to disk
before we rollback the writer otherwise we open a window for potential dataloss due
to stupid errors preventing the translog from being closed.

@s1monw s1monw force-pushed the s1monw:flush_translog_on_engine_close branch from 7936442 to f687377 Apr 8, 2015

@s1monw s1monw merged commit f687377 into elastic:master Apr 8, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@s1monw s1monw added the resiliency label Apr 8, 2015

@s1monw s1monw deleted the s1monw:flush_translog_on_engine_close branch Apr 8, 2015

@clintongormley clintongormley changed the title [ENGINE] sync translog before closing engine Sync translog before closing engine May 29, 2015

@clintongormley clintongormley removed the review label Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.