Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Tuple only as return value in Bootstrap #10784

Merged
merged 1 commit into from Apr 24, 2015

Conversation

Projects
None yet
4 participants
@rmuir
Copy link
Contributor

commented Apr 24, 2015

I wanted to raise this separately (it impacts more of the code than just here). I think in general this Tuple should just be used only as a return-value mechanism and then unboxed by calling code. Otherwise we are stuck working with "variable" names v1 and v2, which can make code hard to follow: you only have types and no context about the instances.

@kimchy

This comment has been minimized.

Copy link
Member

commented Apr 24, 2015

LGTM, ++

@mikemccand

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2015

LGTM

@rmuir rmuir referenced this pull request Apr 24, 2015

Closed

Unbox Tuple at call sites. #10787

@rmuir rmuir added the v2.0.0-beta1 label Apr 24, 2015

rmuir added a commit that referenced this pull request Apr 24, 2015

Merge pull request #10784 from rmuir/reformat_bootstrap
Use Tuple only as return value in Bootstrap

@rmuir rmuir merged commit 31dc26e into elastic:master Apr 24, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.