Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Immediately clear the filter cache when requested #10812

Closed
wants to merge 5 commits into from
Closed

[Fix] Immediately clear the filter cache when requested #10812

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2015

Fixes #8285

@dakrone splitting up my previous pull request #10178 as requested.

@clintongormley
Copy link

@jpountz is this change still relevant given the reworking of queries/filters in master?

@kimchy
Copy link
Member

kimchy commented Apr 26, 2015

this fix is problematic, since it clears all the filters on the node level, not only the ones relating to a this specific index. Also, the reference to #8285 is incorrect, as its a different case of problem, its not the fact that cleanup is not called on the guava cache.

We can make IndicesFilterCache#ReaderCleaner a instance variable and explicitly call something like "forceCleanup" (synchronized) that calls the the parts of the run method (without scheduling another run) that ends up cleaning the respective parts relating to that index.

@jpountz
Copy link
Contributor

jpountz commented Apr 27, 2015

@clintongormley If we move to the Lucene filter cache, this should not be necessary since it has synchronous removals.

@clintongormley
Copy link

thanks @jpountz.

thanks for the PR @Myll but I think we won't fix it as the whole mechanism is changing with Lucene 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Immediately clear the filter cache when requested
4 participants