Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to let eclipse ignore the antigun plugin in it's maven integration #10822

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@colings86
Copy link
Member

commented Apr 27, 2015

This plugin should be ignored as it will make the internal eclipse build fail when there are NOCOMMIT comments in files, which are expected during feature development. This change only affects eclipse users and only when they are using the m2e eclipse integration

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2015

LGTM

Fix to let eclipse ignore the antigun plugin in it's maven integration
This plugin should be ignored as it will make the internal eclipse build fail when there are NOCOMMIT comments in files, which are expected during feature development. This change only affects eclipse users and only when they are using the m2e eclipse integration

@colings86 colings86 force-pushed the colings86:fix/eclipseLifecycle branch from 4e441a1 to 668fd24 Apr 27, 2015

@colings86

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2015

Pushed to master and 1.x

@colings86 colings86 closed this Apr 27, 2015

@kevinkluge kevinkluge removed the review label Apr 27, 2015

@colings86 colings86 deleted the colings86:fix/eclipseLifecycle branch Apr 27, 2015

@clintongormley clintongormley removed the >bug label Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.