Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core delete-by-query implementation #10859

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@mikemccand
Copy link
Contributor

commented Apr 28, 2015

This removes the core implementation of DBQ, which is trappy because it does an unexpected refresh every time and it can create inconsistent replicas since they can delete different documents from one another and the primary. See #10067 for details.

The plan is to create a separate "scan/scroll/delete" plugin for 2.0, which will do a scan/scroll query and then bulk-delete the IDs, for users who really need DBQ but can't implement it client side on upgrade.

I left DBQ in Translog / IndexShard / InternalEngine so that on upgrade if a DBQ is in the translog it can still be applied.

On backport to 1.x I'll just add back the deprecations in the docs and public APIs.

mikemccand added some commits Apr 28, 2015

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2015

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.