-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESQL: Lock testing to LEFT joins only #110165
Merged
elasticsearchmachine
merged 5 commits into
elastic:main
from
nik9000:esql_lookup_test_left_only
Jun 26, 2024
Merged
ESQL: Lock testing to LEFT joins only #110165
elasticsearchmachine
merged 5 commits into
elastic:main
from
nik9000:esql_lookup_test_left_only
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only support LEFT joins at the moment and the tests would randomly fail. Closes elastic#110158 Closes elastic#110152
nik9000
added
>test
Issues or PRs that are addressing/adding tests
auto-merge
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Analytics/ES|QL
AKA ESQL
v8.15.0
labels
Jun 25, 2024
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
label
Jun 25, 2024
not-napoleon
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can see why that would randomly fail.
alex-spies
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nik!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
auto-merge
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
>test
Issues or PRs that are addressing/adding tests
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only support LEFT joins at the moment and the tests would randomly fail.
Closes #110158
Closes #110152