Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Lock testing to LEFT joins only #110165

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jun 25, 2024

We only support LEFT joins at the moment and the tests would randomly fail.

Closes #110158
Closes #110152

We only support LEFT joins at the moment and the tests would randomly
fail.

Closes elastic#110158
Closes elastic#110152
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Analytics/ES|QL AKA ESQL v8.15.0 labels Jun 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 25, 2024
Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can see why that would randomly fail.

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nik!

@elasticsearchmachine elasticsearchmachine merged commit 2a6bd5c into elastic:main Jun 26, 2024
15 checks passed
@nik9000 nik9000 deleted the esql_lookup_test_left_only branch June 26, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] EsqlNodeSubclassTests testInfoParameters failure [CI] EsqlNodeSubclassTests testReplaceChildren failing
4 participants