Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the `top_children` query #11022

Merged
merged 1 commit into from May 7, 2015

Conversation

@martijnvg
Copy link
Member

commented May 6, 2015

Deprecate the top_children query in favour of the has_child query.

The top_children query isn't always faster than the has_child query and the top_children query is often inaccurate. The total hits and any aggregations in the same search request will likely be off. The has_child query performance has improved over time and will improve more when #6511 lands.

@martijnvg martijnvg changed the title parent/child: Deprecate the `top_children` queryin favour of the `has_chi… parent/child: Deprecate the `top_children` query May 6, 2015
@martijnvg martijnvg force-pushed the martijnvg:top_children/deprecation branch from 97a9faf to d44a5f4 May 6, 2015
@kimchy

This comment has been minimized.

Copy link
Member

commented May 6, 2015

LGTM

@jpountz

This comment has been minimized.

Copy link
Contributor

commented May 6, 2015

Do we want to have it removed in 2.0 or only deprecated?

@martijnvg

This comment has been minimized.

Copy link
Member Author

commented May 6, 2015

@jpountz My plan was to remove top_children from master when this PR gets merged.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented May 6, 2015

Awesome :)

@martijnvg martijnvg force-pushed the martijnvg:top_children/deprecation branch from d44a5f4 to f7c2945 May 7, 2015
@martijnvg martijnvg merged commit f7c2945 into elastic:master May 7, 2015
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
@kevinkluge kevinkluge removed the review label May 7, 2015
@martijnvg martijnvg deleted the martijnvg:top_children/deprecation branch May 18, 2015
@clintongormley clintongormley changed the title parent/child: Deprecate the `top_children` query Deprecate the `top_children` query May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.