Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Holt-Winters to moving_avg aggregation #11043
+1,204
−99
Conversation
polyfractal
added
v2.0.0-beta1
review
:Search/Aggregations
labels
May 7, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
@polyfractal left some comments but it looks pretty good |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
@colings86 All tidied up :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
LGTM |
added a commit
that referenced
this pull request
May 27, 2015
polyfractal
merged commit 5acb40c
into
elastic:master
May 27, 2015
1 check passed
CLA
Commit author is a member of Elasticsearch
Details
kevinkluge
removed
the
review
label
May 27, 2015
clintongormley
added
the
>feature
label
May 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
polyfractal commentedMay 7, 2015
Adds Holt-Winters model (aka triple exponential) to
moving_avgaggregation. Holt-Winters has some finicky properties, so there were general changes to the agg to help make life easier:settingshash parsing, such that proper SearchParsePhaseExceptions are thrown if the datatype is wrong, out of bounds, etchasNext()to determine if the model is capable of producing a new value. This is important for HW, which has a "cold start" phase at the beginning where it is incapable of producing values.reduce()method