[Gradle] Simplify Build Scan setup #112347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
added
the
auto-merge-without-approval
mark-vieira
approved these changes
Aug 29, 2024
| // Disable async upload in CI to ensure scan upload completes before CI agent is terminated | ||
| uploadInBackground = false | ||
|
|
||
| if (buildKiteUrl) { //Buildkite-specific build scan metadata |
Contributor
There was a problem hiding this comment.
Do we even need this conditional then? Given that if we are in CI, we are by definition running in Buildkite.
Contributor
Author
There was a problem hiding this comment.
I changed the conditional, but we still need to differ between ci and not ci. though you're right. CI basically means buildkite.
remove jenkins specific logic
breskeby
force-pushed
the
simplify-build-scan-setup
branch
from
6090dcd to
574894f
Compare
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Aug 30, 2024
- remove jenkins specific logic - more simplification on build scan build logic
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
- remove jenkins specific logic - more simplification on build scan build logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove jenkins specific logic